From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: David Herrmann <dh.herrmann@gmail.com>, netdev@vger.kernel.org
Cc: "David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: drop write-only stack variable
Date: Tue, 2 Feb 2016 21:50:21 +0100 [thread overview]
Message-ID: <56B1168D.6070201@stressinduktion.org> (raw)
In-Reply-To: <1454433474-8888-1-git-send-email-dh.herrmann@gmail.com>
On 02.02.2016 18:17, David Herrmann wrote:
> Remove a write-only stack variable from unix_attach_fds(). This is a
> left-over from the security fix in:
>
> commit 712f4aad406bb1ed67f3f98d04c044191f0ff593
> Author: willy tarreau <w@1wt.eu>
> Date: Sun Jan 10 07:54:56 2016 +0100
>
> unix: properly account for FDs passed over unix sockets
>
> Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
I don't think this specifically needs a Fixes tag. Seems more like a
clean-up.
Anyway, I also noticed this during review and it can be removed safely.
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Thanks,
Hannes
next prev parent reply other threads:[~2016-02-02 20:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 17:17 [PATCH] net: drop write-only stack variable David Herrmann
2016-02-02 17:53 ` Sergei Shtylyov
2016-02-02 20:50 ` Hannes Frederic Sowa [this message]
2016-02-07 19:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B1168D.6070201@stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=dh.herrmann@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).