From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: Nikolay Aleksandrov <razor@blackwall.org>, netdev@vger.kernel.org
Cc: stannous@cumulusnetworks.com, roopa@cumulusnetworks.com,
stephen@networkplumber.org
Subject: Re: [PATCH iproute2] iplink: bond_slave: fix ad_actor/partner_oper_port_state output
Date: Mon, 8 Feb 2016 21:56:32 +0100 [thread overview]
Message-ID: <56B90100.6@cumulusnetworks.com> (raw)
In-Reply-To: <1454948038-1090-1-git-send-email-razor@blackwall.org>
On 02/08/2016 05:13 PM, Nikolay Aleksandrov wrote:
> From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>
> It seems that I've made a mistake when I exported these, instead of a
> space in the end I've put a newline character which is wrong and breaks
> the single line output.
>
> Fixes: 7d6bc3b87abad ("bonding: export 3ad actor and partner port state")
> Reported-by: Sam Tannous <stannous@cumulusnetworks.com>
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> ---
> ip/iplink_bond_slave.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
I'm not sure if this patch is appropriate as there might be scripts that already
parse it like this (with newline at the end). So if it's not acceptable I can suggest
a different approach where iplink_bond_slave will account for the "oneline" argument
and only then print it with a space so people will have an option. But currently
this breaks the one line "way" of printing that all other iplink users are doing.
next prev parent reply other threads:[~2016-02-08 20:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 16:13 [PATCH iproute2] iplink: bond_slave: fix ad_actor/partner_oper_port_state output Nikolay Aleksandrov
2016-02-08 20:56 ` Nikolay Aleksandrov [this message]
2016-02-09 17:21 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B90100.6@cumulusnetworks.com \
--to=nikolay@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=roopa@cumulusnetworks.com \
--cc=stannous@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).