From: Ivan Vecera <ivecera@redhat.com>
To: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org
Cc: davem@davemloft.net, idosch@mellanox.com, eladr@mellanox.com,
yotamg@mellanox.com, ogerlitz@mellanox.com, yishaih@mellanox.com,
dledford@redhat.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com, eugenia@mellanox.com,
roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
hadarh@mellanox.com, jhs@mojatatu.com, john.fastabend@gmail.com,
jeffrey.t.kirsher@intel.com, jbenc@redhat.com
Subject: Re: [patch net-next RFC 1/6] Introduce devlink infrastructure
Date: Thu, 11 Feb 2016 15:31:36 +0100 [thread overview]
Message-ID: <56BC9B48.5080708@redhat.com> (raw)
In-Reply-To: <1454496482-13961-2-git-send-email-jiri@resnulli.us>
On 3.2.2016 11:47, Jiri Pirko wrote:
> +struct devlink_ops {
> + size_t priv_size;
> + int (*port_type_set)(struct devlink_port *devlink_port,
> + enum devlink_port_type port_type);
> +};
It does not make sense to have priv_size member here... If it is
necessary it should be placed in struct devlink.
Ivan
next prev parent reply other threads:[~2016-02-11 14:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 10:47 [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it Jiri Pirko
2016-02-03 10:47 ` [patch net-next RFC 1/6] Introduce devlink infrastructure Jiri Pirko
2016-02-11 14:31 ` Ivan Vecera [this message]
2016-02-11 16:54 ` Jiri Pirko
2016-02-03 10:47 ` [patch net-next RFC 2/6] mlxsw: Implement devlink interface Jiri Pirko
2016-02-03 10:47 ` [patch net-next RFC 3/6] mlxsw: Implement hardware messages notification using devlink Jiri Pirko
2016-02-03 10:48 ` [patch net-next RFC 4/6] mlx4: Implement devlink interface Jiri Pirko
2016-02-16 16:43 ` Or Gerlitz
2016-02-16 16:51 ` Jiri Pirko
2016-02-03 10:48 ` [patch net-next RFC 5/6] mlx4: Implement hardware messages notification using devlink Jiri Pirko
2016-02-03 10:48 ` [patch net-next RFC 6/6] mlx4: Implement port type setting via devlink interface Jiri Pirko
2016-02-03 13:31 ` [patch net-next RFC 0/6] Introduce devlink interface and first drivers to use it Jesper Dangaard Brouer
2016-02-03 13:33 ` Jiri Pirko
2016-02-03 15:17 ` Daniel Borkmann
2016-02-04 13:22 ` Hannes Frederic Sowa
2016-02-04 13:26 ` Jiri Pirko
2016-02-05 10:01 ` Hannes Frederic Sowa
2016-02-05 17:38 ` Alexei Starovoitov
2016-02-06 19:40 ` Jiri Pirko
2016-02-08 10:15 ` Hannes Frederic Sowa
2016-02-08 10:55 ` Jiri Pirko
2016-02-08 12:11 ` Hannes Frederic Sowa
2016-02-04 19:01 ` Rosen, Rami
2016-02-05 14:29 ` Jesper Dangaard Brouer
2016-02-07 20:18 ` roopa
2016-02-08 19:00 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BC9B48.5080708@redhat.com \
--to=ivecera@redhat.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=eladr@mellanox.com \
--cc=eugenia@mellanox.com \
--cc=hadarh@mellanox.com \
--cc=hal.rosenstock@gmail.com \
--cc=idosch@mellanox.com \
--cc=jbenc@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=ogerlitz@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=sean.hefty@intel.com \
--cc=yishaih@mellanox.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).