* [PATCH net-next] bnx2x: Add missing HSI for big-endian machines
@ 2016-02-17 11:15 Yuval Mintz
2016-02-17 14:01 ` Sergei Shtylyov
2016-02-19 4:33 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Yuval Mintz @ 2016-02-17 11:15 UTC (permalink / raw)
To: davem, netdev; +Cc: Ariel.Elior, Yuval Mintz
Commit e5d3a51cefbb "bnx2x: extend DCBx support" was missing HSI changes
for big-endian machine, breaking compilation on such platforms.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
---
Hi Dave,
Sorry about this. Please consider applying this to `net-next'.
Thanks,
Yuval
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h
index dd9d6e6..04523d4 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h
@@ -1824,10 +1824,12 @@ struct dcbx_app_priority_entry {
u8 pri_bitmap;
u8 appBitfield;
#define DCBX_APP_ENTRY_VALID 0x01
- #define DCBX_APP_ENTRY_SF_MASK 0x30
+ #define DCBX_APP_ENTRY_SF_MASK 0xF0
#define DCBX_APP_ENTRY_SF_SHIFT 4
#define DCBX_APP_SF_ETH_TYPE 0x10
#define DCBX_APP_SF_PORT 0x20
+ #define DCBX_APP_SF_UDP 0x40
+ #define DCBX_APP_SF_DEFAULT 0x80
#elif defined(__LITTLE_ENDIAN)
u8 appBitfield;
#define DCBX_APP_ENTRY_VALID 0x01
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] bnx2x: Add missing HSI for big-endian machines
2016-02-17 11:15 [PATCH net-next] bnx2x: Add missing HSI for big-endian machines Yuval Mintz
@ 2016-02-17 14:01 ` Sergei Shtylyov
2016-02-17 14:06 ` Yuval Mintz
2016-02-19 4:33 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2016-02-17 14:01 UTC (permalink / raw)
To: Yuval Mintz, davem, netdev; +Cc: Ariel.Elior
Hello.
On 2/17/2016 2:15 PM, Yuval Mintz wrote:
> Commit e5d3a51cefbb "bnx2x: extend DCBx support" was missing HSI changes
You forgot to also enclose the commit summary in parens.
> for big-endian machine, breaking compilation on such platforms.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH net-next] bnx2x: Add missing HSI for big-endian machines
2016-02-17 14:01 ` Sergei Shtylyov
@ 2016-02-17 14:06 ` Yuval Mintz
0 siblings, 0 replies; 4+ messages in thread
From: Yuval Mintz @ 2016-02-17 14:06 UTC (permalink / raw)
To: Sergei Shtylyov, David Miller, netdev; +Cc: Ariel Elior
> > Commit e5d3a51cefbb "bnx2x: extend DCBx support" was missing HSI
> changes
> You forgot to also enclose the commit summary in parens.
Good to see we've managed to fix everything else.
:-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] bnx2x: Add missing HSI for big-endian machines
2016-02-17 11:15 [PATCH net-next] bnx2x: Add missing HSI for big-endian machines Yuval Mintz
2016-02-17 14:01 ` Sergei Shtylyov
@ 2016-02-19 4:33 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2016-02-19 4:33 UTC (permalink / raw)
To: Yuval.Mintz; +Cc: netdev, Ariel.Elior
From: Yuval Mintz <Yuval.Mintz@qlogic.com>
Date: Wed, 17 Feb 2016 13:15:14 +0200
> Commit e5d3a51cefbb "bnx2x: extend DCBx support" was missing HSI changes
> for big-endian machine, breaking compilation on such platforms.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-19 4:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-17 11:15 [PATCH net-next] bnx2x: Add missing HSI for big-endian machines Yuval Mintz
2016-02-17 14:01 ` Sergei Shtylyov
2016-02-17 14:06 ` Yuval Mintz
2016-02-19 4:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).