From: John Fastabend <john.fastabend@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>, Jiri Pirko <jiri@resnulli.us>
Cc: amir@vadai.me, davem@davemloft.net, netdev@vger.kernel.org,
jeffrey.t.kirsher@intel.com
Subject: Re: [net-next PATCH v3 7/8] net: ixgbe: add support for tc_u32 offload
Date: Wed, 17 Feb 2016 06:25:36 -0800 [thread overview]
Message-ID: <56C482E0.2080200@gmail.com> (raw)
In-Reply-To: <56C45DC3.1050607@mojatatu.com>
On 16-02-17 03:47 AM, Jamal Hadi Salim wrote:
> On 16-02-17 06:42 AM, Jiri Pirko wrote:
>> Wed, Feb 17, 2016 at 12:17:26PM CET, jhs@mojatatu.com wrote:
>>> On 16-02-17 12:18 AM, John Fastabend wrote:
>
>>>
>>> Note: i dont see anything that says "hw". Are you delegating ht 0x800
>>> for h/w only? It is the default ht; so may not be the best choice.
>>
>> That is not implemented in this patchset. hw/sw/hwsw flag will be done
>> in a follow up. So far, the user has only possibility to enable/disable
>> the whole thing by ethtool feature flag.
>
> [..]
>>> All looks cool but I am just worried about the lack of intent that
>>> something needs to go to hw vs sw. Other worry:
>>> What happens when things fail to install in hw?
>>
>> Silently fail. I believe that this should be handled in the same
>> follow-up I referred to above.
>>
>
> I can live with the above. John, please consider my comments when
> sending next update.
> So only outstanding issue is you need to fix that NEW with REPLACE
> in patch 3.
>
Perfect. I'm sending an update for patch 3 now and I'll carry all
your Acks forward thanks for the review Jamal.
> For this patch:
> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
>
> cheers,
> jamal
>
>
next prev parent reply other threads:[~2016-02-17 14:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 5:15 [net-next PATCH v3 0/8] tc offload for cls_u32 on ixgbe John Fastabend
2016-02-17 5:16 ` [net-next PATCH v3 1/8] net: rework ndo tc op to consume additional qdisc handle parameter John Fastabend
2016-02-17 10:42 ` Jamal Hadi Salim
2016-02-17 5:16 ` [net-next PATCH v3 2/8] net: rework setup_tc ndo op to consume general tc operand John Fastabend
2016-02-17 10:42 ` Jamal Hadi Salim
2016-02-17 5:17 ` [net-next PATCH v3 3/8] net: sched: add cls_u32 offload hooks for netdevs John Fastabend
2016-02-17 7:02 ` Jiri Pirko
2016-02-17 10:59 ` Jamal Hadi Salim
2016-02-17 14:24 ` John Fastabend
2016-02-17 23:07 ` John Fastabend
2016-02-18 9:23 ` Amir Vadai"
2016-02-19 3:37 ` Simon Horman
2016-02-19 8:16 ` Or Gerlitz
2016-02-18 12:14 ` Jamal Hadi Salim
2016-02-18 15:24 ` John Fastabend
2016-02-19 12:52 ` Jamal Hadi Salim
2016-02-17 5:17 ` [net-next PATCH v3 4/8] net: add tc offload feature flag John Fastabend
2016-02-17 11:01 ` Jamal Hadi Salim
2016-02-17 5:18 ` [net-next PATCH v3 5/8] net: tc: helper functions to query action types John Fastabend
2016-02-17 7:03 ` Jiri Pirko
2016-02-17 11:02 ` Jamal Hadi Salim
2016-02-17 5:18 ` [net-next PATCH v3 6/8] net: ixgbe: add minimal parser details for ixgbe John Fastabend
2016-02-17 11:06 ` Jamal Hadi Salim
2016-02-17 15:09 ` David Miller
2016-02-17 15:14 ` John Fastabend
2016-02-17 18:01 ` Rustad, Mark D
2016-02-17 22:34 ` John Fastabend
2016-02-17 5:18 ` [net-next PATCH v3 7/8] net: ixgbe: add support for tc_u32 offload John Fastabend
2016-02-17 11:17 ` Jamal Hadi Salim
2016-02-17 11:42 ` Jiri Pirko
2016-02-17 11:47 ` Jamal Hadi Salim
2016-02-17 14:25 ` John Fastabend [this message]
2016-02-17 5:19 ` [net-next PATCH v3 8/8] net: ixgbe: abort with cls u32 divisor groups greater than 1 John Fastabend
2016-02-17 14:48 ` [net-next PATCH v3 0/8] tc offload for cls_u32 on ixgbe David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C482E0.2080200@gmail.com \
--to=john.fastabend@gmail.com \
--cc=amir@vadai.me \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).