From: Florian Fainelli <f.fainelli@gmail.com>
To: Jaedon Shin <jaedon.shin@gmail.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Petri Gynther <pgynther@google.com>,
opendmb@gmail.com
Subject: Re: [PATCH] net: bcmgenet: Add MDIO_INTR in GENETv2
Date: Thu, 18 Feb 2016 21:47:45 -0800 [thread overview]
Message-ID: <56C6AC81.5020508@gmail.com> (raw)
In-Reply-To: <6BEA4AB8-F99A-4D8D-847F-C5691F3EE1DB@gmail.com>
Hi Jaedon
Le 15/02/2016 19:12, Jaedon Shin a écrit :
>
> As you said, the part in bcmgenet_irq_task() is a problem.
>
> The bcmgenet using internal PHY should use phy_mac_interrupt() cause it has not
> PHY_POLL, and it depends on Ethernet MAC ISR.
>
> UMAC_IRQ_LINK_EVENT(LINK_UP and LINK_DOWN) was working correctly in GENETv2,
> but (priv->hw_params->flags & GENET_HAS_MDIO_INTR) was blocking to call
> phy_mac_interrupt(). I didn't find a reason through datasheet without MDIO_INTR
> in GENETv2. However, I'm not sure using MDIO_INTR.
>
> Therefore if MDIO_INTR is not valid in GENETv2, I will send the patch again
> to remove the first chicken GENET_HAS_MDIO_INTR after your confirm.
MDIO interrupts are wired in GENETv2, so the second part of your patch
is correct, I see now that you have submitted a proper fix for the Link
UP/DOWN event condition, and thank you for doing that. FWIW, all GENET
versions have link UP/DOWN interrupts.
prev parent reply other threads:[~2016-02-19 5:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 8:42 [PATCH] net: bcmgenet: Add MDIO_INTR in GENETv2 Jaedon Shin
2016-02-15 18:18 ` Florian Fainelli
2016-02-16 3:12 ` Jaedon Shin
2016-02-19 5:47 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C6AC81.5020508@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=jaedon.shin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pgynther@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).