From: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
<santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [net-next][PATCH 11/13] RDS: IB: add Fastreg MR (FRMR) detection support
Date: Mon, 22 Feb 2016 07:38:38 -0800 [thread overview]
Message-ID: <56CB2B7E.5000402@sandisk.com> (raw)
In-Reply-To: <20160221.223656.2213596964617869651.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
On 02/21/16 19:36, David Miller wrote:
> From: Santosh Shilimkar <santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Date: Sat, 20 Feb 2016 03:30:02 -0800
>
>> @@ -54,6 +55,8 @@ module_param(rds_ib_mr_8k_pool_size, int, 0444);
>> MODULE_PARM_DESC(rds_ib_mr_8k_pool_size, " Max number of 8K mr per HCA");
>> module_param(rds_ib_retry_count, int, 0444);
>> MODULE_PARM_DESC(rds_ib_retry_count, " Number of hw retries before reporting an error");
>> +module_param(prefer_frmr, bool, 0444);
>> +MODULE_PARM_DESC(prefer_frmr, "Preferred MR method if both FMR and FRMR supported");
>
> Sorry, you're going to have to create a real run time method to configure
> this parameter.
>
> I'm strongly against module parameters.
>
> Please don't go into details about why this might be difficult to do,
> I'm totally not interested. Doing things properly is sometimes not
> easy, that's life.
Hello Santosh,
What is the purpose of the prefer_frmr kernel module parameter ? Is this
a parameter that is useful to RDS users or is its only purpose to allow
developers of the RDS module to test both the FMR and FRMR code paths on
hardware that supports both MR methods ?
Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-22 15:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 11:29 [net-next][PATCH 00/13] RDS: Major clean-up with couple of new features for 4.6 Santosh Shilimkar
2016-02-20 11:29 ` [net-next][PATCH 02/13] RDS: Add support for SO_TIMESTAMP for incoming messages Santosh Shilimkar
2016-02-20 11:29 ` [net-next][PATCH 03/13] MAINTAINERS: update RDS entry Santosh Shilimkar
2016-02-20 11:29 ` [net-next][PATCH 07/13] RDS: IB: move FMR code to its own file Santosh Shilimkar
2016-02-20 11:30 ` [net-next][PATCH 09/13] RDS: IB: handle the RDMA CM time wait event Santosh Shilimkar
[not found] ` <1455967804-27644-1-git-send-email-santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-02-20 11:29 ` [net-next][PATCH 01/13] RDS: Drop stale iWARP RDMA transport Santosh Shilimkar
2016-02-20 11:29 ` [net-next][PATCH 04/13] RDS: IB: Remove the RDS_IB_SEND_OP dependency Santosh Shilimkar
2016-02-20 11:29 ` [net-next][PATCH 05/13] RDS: IB: Re-organise ibmr code Santosh Shilimkar
2016-02-20 11:29 ` [net-next][PATCH 06/13] RDS: IB: create struct rds_ib_fmr Santosh Shilimkar
2016-02-20 11:29 ` [net-next][PATCH 08/13] RDS: IB: add connection info to ibmr Santosh Shilimkar
2016-02-20 11:30 ` [net-next][PATCH 10/13] RDS: IB: add mr reused stats Santosh Shilimkar
2016-02-20 11:30 ` [net-next][PATCH 11/13] RDS: IB: add Fastreg MR (FRMR) detection support Santosh Shilimkar
[not found] ` <1455967804-27644-12-git-send-email-santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-02-22 3:36 ` David Miller
[not found] ` <20160221.223656.2213596964617869651.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2016-02-22 15:38 ` Bart Van Assche [this message]
2016-02-22 16:38 ` santosh shilimkar
2016-02-20 11:30 ` [net-next][PATCH 12/13] RDS: IB: allocate extra space on queues for FRMR support Santosh Shilimkar
2016-02-20 11:30 ` [net-next][PATCH 13/13] RDS: IB: Support Fastreg MR (FRMR) memory registration mode Santosh Shilimkar
-- strict thread matches above, loose matches on Subject: below --
2016-02-27 5:43 [net-next][PATCH 00/13] RDS: Major clean-up with couple of new features for 4.6 Santosh Shilimkar
2016-02-27 5:43 ` [net-next][PATCH 11/13] RDS: IB: add Fastreg MR (FRMR) detection support Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CB2B7E.5000402@sandisk.com \
--to=bart.vanassche-xdaiopvojttbdgjk7y7tuq@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).