From: Rick Jones <rick.jones2@hpe.com>
To: Tom Herbert <tom@herbertland.com>, Edward Cree <ecree@solarflare.com>
Cc: Jesse Gross <jesse@kernel.org>, Alex Duyck <aduyck@mirantis.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Alexander Duyck <alexander.duyck@gmail.com>
Subject: Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default
Date: Tue, 23 Feb 2016 09:20:25 -0800 [thread overview]
Message-ID: <56CC94D9.4030308@hpe.com> (raw)
In-Reply-To: <CALx6S34Pt++Kg=cp+v+gGFQGEDy=eNHtFvtBwd1z-1d2ixOn7Q@mail.gmail.com>
On 02/23/2016 08:47 AM, Tom Herbert wrote:
> Right, GRO should probably not coalesce packets with non-zero IP
> identifiers due to the loss of information. Besides that, RFC6848 says
> the IP identifier should only be set for fragmentation anyway so there
> shouldn't be any issue and really no need for HW TSO (or LRO) to
> support that.
You sure that is RFC 6848 "Specifying Civic Address Extensions in the
Presence Information Data Format Location Object (PIDF-LO)" ?
In whichever RFC that may be, is it a SHOULD or a MUST, and just how
many "other" stacks might be setting a non-zero IP ID on fragments with
DF set?
rick jones
> We need to do increment IP identifier in UFO, but I only see one
> device (neterion) that advertises NETIF_F_UFO-- honestly, removing
> that feature might be another good simplification!
>
> Tom
>
>> --
>> -Ed
next prev parent reply other threads:[~2016-02-23 17:20 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 19:26 [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default Alexander Duyck
2016-02-19 19:26 ` [net-next PATCH 1/2] GENEVE: Support outer IPv4 Tx checksums " Alexander Duyck
2016-02-19 20:28 ` Tom Herbert
2016-02-19 19:26 ` [net-next PATCH 2/2] VXLAN: " Alexander Duyck
2016-02-19 20:27 ` Tom Herbert
2016-02-19 21:36 ` Jesse Gross
2016-02-19 21:53 ` [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum " Jesse Gross
2016-02-19 23:10 ` Alex Duyck
2016-02-20 0:08 ` Jesse Gross
2016-02-20 0:14 ` Tom Herbert
2016-02-20 2:18 ` Jesse Gross
2016-02-20 19:51 ` Tom Herbert
2016-02-23 3:31 ` Jesse Gross
2016-02-23 15:18 ` Edward Cree
2016-02-23 16:47 ` Tom Herbert
2016-02-23 17:20 ` Rick Jones [this message]
2016-02-23 17:38 ` Edward Cree
2016-02-23 18:08 ` David Miller
2016-02-23 20:20 ` Edward Cree
2016-02-23 23:11 ` David Miller
2016-02-24 0:53 ` Tom Herbert
2016-02-24 17:30 ` Edward Cree
2016-02-23 18:11 ` Tom Herbert
2016-02-23 17:31 ` Jesse Gross
2016-02-23 17:42 ` Tom Herbert
2016-02-23 18:18 ` Alexander Duyck
2016-02-23 18:26 ` David Miller
2016-02-23 18:32 ` Tom Herbert
2016-02-23 18:24 ` David Miller
2016-02-24 9:58 ` David Laight
2016-02-24 15:41 ` David Miller
2016-02-25 20:14 ` David Miller
2016-03-11 19:20 ` Generic TSO (was Re: [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default) Edward Cree
2016-03-11 19:57 ` Tom Herbert
2016-03-11 19:59 ` Edward Cree
2016-03-11 20:16 ` Tom Herbert
2016-03-11 20:24 ` Edward Cree
2016-03-11 21:09 ` Alexander Duyck
2016-03-11 21:29 ` Edward Cree
2016-03-11 22:31 ` Alexander Duyck
2016-03-11 22:55 ` Tom Herbert
2016-03-12 5:40 ` Alexander Duyck
2016-03-14 10:26 ` Generic TSO Edward Cree
2016-03-14 10:32 ` Edward Cree
2016-03-14 15:59 ` Alexander Duyck
2016-03-11 20:22 ` David Miller
2016-02-22 3:06 ` [net-next PATCH 0/2] GENEVE/VXLAN: Enable outer Tx checksum by default David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC94D9.4030308@hpe.com \
--to=rick.jones2@hpe.com \
--cc=aduyck@mirantis.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=jesse@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).