From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Kyeong Yoo <Kyeong.Yoo@alliedtelesis.co.nz>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: net_sched: dsmark: use qdisc_dequeue_peeked()
Date: Wed, 2 Mar 2016 17:56:02 +0300 [thread overview]
Message-ID: <56D6FF02.7060003@cogentembedded.com> (raw)
In-Reply-To: <1456891804.3297.51.camel@kyeongy-dl>
Hello.
On 3/2/2016 7:10 AM, Kyeong Yoo wrote:
> This fix is for dsmark similar to 3557619f0f6f7496ed453d4825e24958ab1884e0,
scripts/checkpatch.pl now enforces certain commit citing format, yours
doesn't match it.
> and makes use of qdisc_dequeue_peeked() instead of direct dequeue() call.
>
> First time, wrr peeks dsmark, which will then peek into sfq.
> sfq dequeues an skb and it's stored in sch->gso_skb.
> Next time, wrr tries to dequeue from dsmark, which will call sfq dequeue
> directly. This results skipping the previously peeked skb.
>
> So changed dsmark dequeue to call qdisc_dequeue_peeked() instead to use
> peeked skb if exists.
>
> Also replaced dsmark peek to use qdisc_peek_dequeued() which works correctly
> if previously peeked skb still exists.
>
> Signed-off-by: Kyeong Yoo <kyeong.yoo@alliedtelesis.co.nz>
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-03-02 14:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 4:10 net_sched: dsmark: use qdisc_dequeue_peeked() Kyeong Yoo
2016-03-02 14:56 ` Sergei Shtylyov [this message]
2016-03-02 18:26 ` Cong Wang
2016-03-02 21:19 ` Kyeong Yoo
2016-03-02 22:01 ` Cong Wang
2016-03-03 5:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D6FF02.7060003@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Kyeong.Yoo@alliedtelesis.co.nz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).