From: Brian Russell <brian.russell@brocade.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Brian Russell <brussell@brocade.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v3 0/3] NSH and VxLAN-GPE
Date: Fri, 4 Mar 2016 15:38:47 +0000 [thread overview]
Message-ID: <56D9AC07.4010601@brocade.com> (raw)
In-Reply-To: <20160301181231.GA95346@ast-mbp.thefacebook.com>
On 01/03/16 18:12, Alexei Starovoitov wrote:
> On Tue, Mar 01, 2016 at 11:11:46AM +0000, Brian Russell wrote:
>> These patches add a new module to support encap/decap of Network
>> Service Header (NSH) as defined in:
>>
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__tools.ietf.org_html_draft-2Dietf-2Dsfc-2Dnsh-2D01&d=CwIBAg&c=IL_XqQWOjubgfqINi2jTzg&r=Doie302MT-sezztwQymkPQ3_4X5Q3a0mKbiZzzoNm-0&m=GXnpiqS7PmfkgZFQ49KQrVhoa7H-hyPyPstkZdCi7hQ&s=Ncdq5xpzX-AAUeSDXaoU_zxqfXSdoI_qvgFZVyUclV0&e=
>>
>> Both NSH Type 1 and Type 2 metadata are supported with a simple registration
>> hook to allow listeners to register to see packets with Type 1 or a specific
>> class of Type 2 metadata. NSH could be added to packets sent over a variety
>> of link types, eg. VxLAN, GRE, ethernet.
>>
>> v2 - fix copyright notices and tidy up use of types
>>
>> v3 - fix various style issues in nsh module
>> remove VxLAN-GPE changes
>> add nsh logging module as example
>> add nsh netfilter encap target as example
>
> two fake examples are trying to justify EXPORT_SYMBOL(nsh_register_listener) ?!
> what's the real meaning of this patch set?
> As far as I can see in-tree users cannot do anything useful with it.
>
I don't see what you're getting at. I thought the "real meaning" was obvious?
The NSH draft says:
" Optional Variable Length Metadata
...
TLV Class: describes the scope of the "Type" field. In some cases,
the TLV Class will identify a specific vendor, in others, the TLV
Class will identify specific standards body allocated types. A new
IANA registry will be created for TLV Class type.
Type: the specific type of information being carried, within the
scope of a given TLV Class. Value allocation is the responsibility
of the TLV Class owner."
So it seems reasonable to have a hook to hang metadata interpretation on?
Thanks and regards,
Brian
next prev parent reply other threads:[~2016-03-04 15:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 11:11 [PATCH net-next v3 0/3] NSH and VxLAN-GPE Brian Russell
2016-03-01 11:11 ` [PATCH net-next v3 1/3] nsh: encapsulation module Brian Russell
2016-03-01 11:11 ` [PATCH net-next v3 2/3] nsh: logging module Brian Russell
2016-03-01 18:25 ` Joe Perches
2016-03-04 15:39 ` Brian Russell
2016-03-01 11:11 ` [PATCH net-next v3 3/3] nsh: netfilter target Brian Russell
2016-03-01 18:12 ` [PATCH net-next v3 0/3] NSH and VxLAN-GPE Alexei Starovoitov
2016-03-04 15:38 ` Brian Russell [this message]
2016-03-04 22:14 ` David Miller
2016-03-04 17:15 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D9AC07.4010601@brocade.com \
--to=brian.russell@brocade.com \
--cc=alexei.starovoitov@gmail.com \
--cc=brussell@brocade.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).