From: f6bvp <f6bvp@free.fr>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, ralf@linux-mips.org
Subject: Re: [Patch] rose_route_frame() NULL pointer dereference kernel panic
Date: Sat, 5 Mar 2016 18:32:04 +0100 [thread overview]
Message-ID: <56DB1814.2050902@free.fr> (raw)
In-Reply-To: <20160305.112226.2192524821017178121.davem@davemloft.net>
Le 05/03/2016 17:22, David Miller a écrit :
> From: f6bvp <f6bvp@free.fr>
> Date: Sat, 5 Mar 2016 16:32:42 +0100
>
>> I understand I did not explain clearly or completely things.
>>
>> I agree that each time patched rose_xmit() is calling
>> rose_route_frame() it will
>> get a 0 return.
>> And I think this is what was intended by the author of rose_xmit().
>
> If that's what he intended he would have implemented the entirety of
> rose_xmit() as "kfree_skb(skb)". But that's obviously not the case.
>
> The author meant the packet to be sent in some way, perhaps using a
> default path or something like that.
Via a NULL pointer ?
I don't see how it could work.
>
> So please stop telling me over and over again that this function
> is meant to simply drop all packets, it's not true.
>
I am just making hypothesis and trying to infer some deductions from the
behaviour of program when there is no more kernel panic.
If there is a situation leading to a kernel panic, I thought code should
be changed ?
What is the problem replacing a NULL argument by an array of 0 ?
next prev parent reply other threads:[~2016-03-05 17:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 16:53 [Patch] rose_route_frame() NULL pointer dereference kernel panic f6bvp
2016-02-25 22:09 ` David Miller
2016-03-01 20:37 ` f6bvp
2016-03-03 22:02 ` David Miller
2016-03-05 15:32 ` f6bvp
2016-03-05 16:22 ` David Miller
2016-03-05 17:32 ` f6bvp [this message]
2016-03-05 19:57 ` Francois Romieu
[not found] ` <56DC0B8A.5030708@free.fr>
2016-03-06 10:58 ` f6bvp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DB1814.2050902@free.fr \
--to=f6bvp@free.fr \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).