From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH 0/3] net: macb: Fix coding style issues Date: Mon, 7 Mar 2016 18:13:46 +0100 Message-ID: <56DDB6CA.8000100@atmel.com> References: <1457367460-9123-1-git-send-email-moritz.fischer@ettus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: , To: Moritz Fischer , Michal Simek , Cyrille Pitchen , "David Miller" , Punnaiah Choudary Kalluri Return-path: Received: from eusmtp01.atmel.com ([212.144.249.242]:9577 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752826AbcCGRNi (ORCPT ); Mon, 7 Mar 2016 12:13:38 -0500 In-Reply-To: <1457367460-9123-1-git-send-email-moritz.fischer@ettus.com> Sender: netdev-owner@vger.kernel.org List-ID: Le 07/03/2016 17:17, Moritz Fischer a =E9crit : > Hi Nicolas, >=20 > this series deals with most of the checkpatch warnings > generated for macb. There are two BUG_ON()'s that I didn't touch, yet= , > that were suggested by checkpatch, that I can address in a follow up > commit if needed. > Let me know if you want me to split the fixes differently or squash > them into one commit. Hi, I'm not usually fond of this type of patches, but I must admit that thi= s series corrects some style issues. So, I would like more feedback from Michal and Cyrille as these changes may delay some of the not-merged-yet features or more important work-in-progress on their side. On the other hand, if we all think it's a calm period for this macb driver, we may find interesting to merge some "cleanup and style" enhancements. Thanks, bye, > Moritz Fischer (3): > net: macb: Fix coding style error message > net: macb: Fix more coding style issues > net: macb: Address checkpatch 'check' suggestions >=20 > drivers/net/ethernet/cadence/macb.c | 157 ++++++++++++++++----------= ---------- > 1 file changed, 71 insertions(+), 86 deletions(-) >=20 --=20 Nicolas Ferre