netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lino Sanfilippo <lsanfil@marvell.com>
To: <netdev@vger.kernel.org>
Cc: Lino Sanfilippo <LinoSanfilippo@gmx.de>, <linux-kernel@vger.kernel.org>
Subject: Question concerning function illegal_highdma
Date: Tue, 8 Mar 2016 11:32:26 +0100	[thread overview]
Message-ID: <56DEAA3A.4080207@marvell.com> (raw)


Hi all,

while trying to understand the meaning of the net_device flag NETIF_F_HIGHDMA
I came across the function illegal_highdma() which seems to perform two tasks:

1. Check if a network interface is able to handle high memory pages
2. Check if a network interface is able to handle the resulting DMA addresses

What I dont understand is why both conditions are only checked if CONFIG_HIGHMEM is set.
For 1. this makes sense, of course. But why is 2. also only checked with CONFIG_HIGHMEM?
Should not 2. always be checked, regardless of whether high memory exists in the system or not?

Thanks for any enlightenment in advance!

Regards,
Lino

                 reply	other threads:[~2016-03-08 10:32 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56DEAA3A.4080207@marvell.com \
    --to=lsanfil@marvell.com \
    --cc=LinoSanfilippo@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).