From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Caesar Wang <wxt@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>
Cc: linux-rockchip@lists.infradead.org, keescook@google.com,
leozwang@google.com, Alexander Kochetkov <al.kochet@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] net: arc_emac: support the phy reset for emac driver
Date: Fri, 11 Mar 2016 22:22:00 +0300 [thread overview]
Message-ID: <56E31AD8.3060201@cogentembedded.com> (raw)
In-Reply-To: <1457693731-6966-4-git-send-email-wxt@rock-chips.com>
On 03/11/2016 01:55 PM, Caesar Wang wrote:
> This patch adds to support the emac phy reset.
>
> 1) phy-reset-gpios:
> The phy-reset-gpios is an optional property for arc emac device tree boot.
> Change the binding document to match the driver code.
>
> 2) phy-reset-duration:
> Different boards may require different phy reset duration. Add property
> phy-reset-duration for device tree probe, so that the boards that need
> a longer reset duration can specify it in their device tree.
>
> 3) phy-reset-active-high:
> We need that for a custom hardware that needs the reverse reset sequence.
What concerns me the most about the existing (and suggested) PHY reset
related props is that they are located in the MAC device node while not having
*anything* to do with the MAC at all! These props actually belong to the PHY
nodes, and I'm currently looking into how to handle them there, where they
belong...
> Of course, this patch will fix the issue on
> https://patchwork.kernel.org/patch/8186801/.
>
> In some cases, the emac couldn't work if you don't have reset the phy.
> Let's add it to happy work.
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-03-11 19:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 10:55 [PATCH 0/6] arc_emac: fixes the emac issues oand cleanup emac drivers Caesar Wang
[not found] ` <1457693731-6966-1-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-03-11 10:55 ` [PATCH 3/6] net: arc_emac: support the phy reset for emac driver Caesar Wang
2016-03-11 13:47 ` Sergei Shtylyov
2016-03-11 14:56 ` Heiko Stübner
2016-03-11 14:59 ` Heiko Stübner
2016-03-11 18:35 ` Sergei Shtylyov
2016-03-13 3:57 ` Caesar Wang
2016-03-11 19:22 ` Sergei Shtylyov [this message]
2016-03-11 10:55 ` [PATCH 4/6] net: arc: trivial: cleanup the " Caesar Wang
2016-03-11 11:28 ` kbuild test robot
2016-03-11 13:46 ` [PATCH 0/6] arc_emac: fixes the emac issues oand cleanup emac drivers Sergei Shtylyov
2016-03-11 14:48 ` Caesar Wang
2016-03-11 18:46 ` Sergei Shtylyov
2016-03-13 4:04 ` Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E31AD8.3060201@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=al.kochet@gmail.com \
--cc=davem@davemloft.net \
--cc=heiko@sntech.de \
--cc=keescook@google.com \
--cc=leozwang@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).