From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Subject: Re: [PATCH 1/5] net: macb: Fix coding style error message Date: Mon, 14 Mar 2016 21:47:13 +0100 Message-ID: <56E72351.8020302@xilinx.com> References: <1457896247-25934-1-git-send-email-moritz.fischer@ettus.com> <1457896247-25934-2-git-send-email-moritz.fischer@ettus.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: , , , , , To: Moritz Fischer , Return-path: In-Reply-To: <1457896247-25934-2-git-send-email-moritz.fischer@ettus.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 13.3.2016 20:10, Moritz Fischer wrote: > checkpatch.pl gave the following error: > > ERROR: space required before the open parenthesis '(' > + for(; p < end; p++, offset += 4) > > Signed-off-by: Moritz Fischer > --- > drivers/net/ethernet/cadence/macb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c > index 50c9410..4370f37 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -496,7 +496,7 @@ static void macb_update_stats(struct macb *bp) > > WARN_ON((unsigned long)(end - p - 1) != (MACB_TPF - MACB_PFR) / 4); > > - for(; p < end; p++, offset += 4) > + for (; p < end; p++, offset += 4) > *p += bp->macb_reg_readl(bp, offset); > } > > Acked-by: Michal Simek Thanks, Michal