From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikolay Aleksandrov Subject: Re: [PATCH net-next 4/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_br Date: Wed, 16 Mar 2016 15:14:19 +0100 Message-ID: <56E96A3B.1030907@cumulusnetworks.com> References: <059d608901fd86407fed374e567c46447aa8c88f.1458134414.git.lucien.xin@gmail.com> <45f430c026ce8a2fb358c650a41452aebff9ec36.1458134414.git.lucien.xin@gmail.com> <38a10eecc6347a3c47b55c86b4783c49b6dbbc99.1458134414.git.lucien.xin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, Hannes Frederic Sowa To: Xin Long , network dev Return-path: Received: from mail-wm0-f45.google.com ([74.125.82.45]:36598 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964964AbcCPOOW (ORCPT ); Wed, 16 Mar 2016 10:14:22 -0400 Received: by mail-wm0-f45.google.com with SMTP id l124so50392850wmf.1 for ; Wed, 16 Mar 2016 07:14:22 -0700 (PDT) In-Reply-To: <38a10eecc6347a3c47b55c86b4783c49b6dbbc99.1458134414.git.lucien.xin@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On 03/16/2016 02:34 PM, Xin Long wrote: > Now when we change the attributes of bridge or br_port by netlink, > a relevant netlink notification will be sent, but if we change them > by ioctl or sysfs, no notification will be sent. > > We should ensure that whenever those attributes change internally or from > sysfs/ioctl, that a netlink notification is sent out to listeners. > > Also, NetworkManager will use this in the future to listen for out-of-band > bridge master attribute updates and incorporate them into the runtime > configuration. > > This patch is used for br_sysfs_br. and we also need to remove some > rtnl_trylock in old functions so that we can call it in a common one. > > Signed-off-by: Xin Long > --- > net/bridge/br_sysfs_br.c | 17 ++++++++--------- > net/bridge/br_vlan.c | 30 +++++------------------------- > 2 files changed, 13 insertions(+), 34 deletions(-) > What about the group_addr option ? Changing it will not generate a notification.