From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: Xin Long <lucien.xin@gmail.com>, network dev <netdev@vger.kernel.org>
Cc: davem@davemloft.net, Hannes Frederic Sowa <hannes@stressinduktion.org>
Subject: Re: [PATCH net-next 6/6] bridge: a netlink notification should be sent when those attributes are changed by ioctl
Date: Wed, 16 Mar 2016 15:28:35 +0100 [thread overview]
Message-ID: <56E96D93.2040308@cumulusnetworks.com> (raw)
In-Reply-To: <9cadf4925a11b60a5420406b4eb164e9a2d13b50.1458134414.git.lucien.xin@gmail.com>
On 03/16/2016 02:34 PM, Xin Long wrote:
> Now when we change the attributes of bridge or br_port by netlink,
> a relevant netlink notification will be sent, but if we change them
> by ioctl or sysfs, no notification will be sent.
>
> We should ensure that whenever those attributes change internally or from
> sysfs/ioctl, that a netlink notification is sent out to listeners.
>
> Also, NetworkManager will use this in the future to listen for out-of-band
> bridge master attribute updates and incorporate them into the runtime
> configuration.
>
> This patch is used for ioctl.
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
> net/bridge/br_ioctl.c | 40 ++++++++++++++++++++++++----------------
> 1 file changed, 24 insertions(+), 16 deletions(-)
>
LGTM,
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
next prev parent reply other threads:[~2016-03-16 14:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 13:34 [PATCH net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl Xin Long
2016-03-16 13:34 ` [PATCH net-next 1/6] bridge: add rtnl_lock in fdb_flush in br_sysfs_br.c Xin Long
2016-03-16 13:55 ` Nikolay Aleksandrov
2016-03-16 13:34 ` [PATCH net-next 2/6] bridge: simplify the forward_delay_store by calling store_bridge_parm Xin Long
2016-03-16 13:58 ` Nikolay Aleksandrov
2016-03-16 13:34 ` [PATCH net-next 3/6] bridge: simplify the stp_state_store " Xin Long
2016-03-16 14:06 ` Nikolay Aleksandrov
2016-03-16 13:34 ` [PATCH net-next 4/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_br Xin Long
2016-03-16 14:14 ` Nikolay Aleksandrov
2016-03-16 14:29 ` Xin Long
2016-03-16 14:33 ` Nikolay Aleksandrov
2016-03-16 13:34 ` [PATCH net-next 5/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_if Xin Long
2016-03-16 14:23 ` Nikolay Aleksandrov
2016-03-16 14:45 ` Xin Long
2016-03-16 14:49 ` Xin Long
2016-03-16 14:49 ` Nikolay Aleksandrov
2016-03-16 14:58 ` Xin Long
2016-03-16 13:34 ` [PATCH net-next 6/6] bridge: a netlink notification should be sent when those attributes are changed by ioctl Xin Long
2016-03-16 14:28 ` Nikolay Aleksandrov [this message]
2016-03-16 14:30 ` [PATCH net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl Nikolay Aleksandrov
2016-03-16 14:59 ` Xin Long
2016-03-17 3:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E96D93.2040308@cumulusnetworks.com \
--to=nikolay@cumulusnetworks.com \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).