From: "Andreas Färber" <afaerber@suse.de>
To: David Daney <ddaney@caviumnetworks.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Robert Richter <rric@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
netdev@vger.kernel.org, David Daney <david.daney@cavium.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
David Daney <ddaney.cavm@gmail.com>,
Kumar Gala <galak@codeaurora.org>,
Sunil Goutham <sgoutham@cavium.com>,
Radha Mohan Chintakuntla <rchintakuntla@cavium.com>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses.
Date: Thu, 17 Mar 2016 00:24:45 +0100 [thread overview]
Message-ID: <56E9EB3D.6050406@suse.de> (raw)
In-Reply-To: <56E9E43A.6000304@caviumnetworks.com>
Am 16.03.2016 um 23:54 schrieb David Daney:
> On 03/16/2016 03:50 PM, Andreas Färber wrote:
>> Am 11.03.2016 um 18:53 schrieb David Daney:
>>> diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
>>> index 40faec9..075a4cc 100644
>>> --- a/drivers/net/phy/Kconfig
>>> +++ b/drivers/net/phy/Kconfig
>>> @@ -196,6 +196,17 @@ config MDIO_OCTEON
>>> buses. It is required by the Octeon and ThunderX ethernet device
>>> drivers on some systems.
>>>
>>> +config MDIO_THUNDER
>>> + tristate "Support for MDIO buses on on ThunderX SOCs"
>>
>> Double "on", spotted in next-20160316.
>>
>>> + depends on 64BIT
>>> + depends on PCI
>>> + select MDIO_CAVIUM
>>> + help
>>> + This driver supports the MDIO interfaces found on Cavium
>>> + ThunderX SoCs when the MDIO bus device appears on as a PCI
>>> + device.
>>
>> While at it, this sentence sounds weird. Did you mean s/as/is/? Or is
>> there another verb missing in there?
>
> Should be "... appears as a PCI device."
>
> davem already merged the patch, so this would have to be fixed as a
> follow-on patch.
>
> Since you found this, do you want to send the patch?
Done.
Cheers,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2016-03-16 23:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 17:53 [PATCH v2 0/3] net/phy: Improvements to Cavium Thunder MDIO code David Daney
2016-03-11 17:53 ` [PATCH v2 1/3] net: thunderx: Cleanup PHY probing code David Daney
2016-03-11 17:53 ` [PATCH v2 2/3] phy: mdio-octeon: Refactor into two files/modules David Daney
2016-03-11 17:53 ` [PATCH v2 3/3] phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses David Daney
2016-03-16 22:50 ` Andreas Färber
2016-03-16 22:54 ` David Daney
2016-03-16 23:24 ` Andreas Färber [this message]
2016-03-12 0:08 ` [PATCH v2 0/3] net/phy: Improvements to Cavium Thunder MDIO code David Daney
2016-03-14 19:27 ` David Miller
2016-03-14 20:12 ` David Daney
2016-03-14 20:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E9EB3D.6050406@suse.de \
--to=afaerber@suse.de \
--cc=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=ddaney@caviumnetworks.com \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rchintakuntla@cavium.com \
--cc=robh+dt@kernel.org \
--cc=rric@kernel.org \
--cc=sgoutham@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).