From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luis de Bethencourt Subject: Re: [PATCH] mac80211: fix order of flag descriptions Date: Fri, 18 Mar 2016 17:40:54 +0000 Message-ID: <56EC3DA6.2090105@osg.samsung.com> References: <1458317369-28185-1-git-send-email-luisbg@osg.samsung.com> <1458318955-32070-1-git-send-email-luisbg@osg.samsung.com> <1458322179.26915.2.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: johannes@sipsolutions.net, davem@davemloft.net, linux-wireless@vger.kernel.org, netdev@vger.kernel.org To: Joe Perches , linux-kernel@vger.kernel.org Return-path: In-Reply-To: <1458322179.26915.2.camel@perches.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 18/03/16 17:29, Joe Perches wrote: > On Fri, 2016-03-18 at 16:35 +0000, Luis de Bethencourt wrote: >> Fix order of mac80211_rx_flags description to match the enum. >> >> Signed-off-by: Luis de Bethencourt >> --- >> Hi, >> >> I want ahead and fixed the order of the descriptions. checkpatch.pl was giving >> a warning to my previous patch and I had a hunch it was because the wrong order >> breaks the parser. Indeed it does and with this patch below checkpatch.pl does >> not complain about this flag descriptions anymore. > > checkpatch complains? About what? > warning: Enum value 'RX_FLAG_DUP_VALIDATED' not described in enum 'mac80211_rx_flags' Is the warning checkpatch.pl gives against my first patch (add doc for RX_FLAG_DUP_VALIDATED flag). This is silenced by reordering the descriptions to match the order in the enum. Thanks, Luis