From mboxrd@z Thu Jan 1 00:00:00 1970 From: oulijun Subject: Re: [PATCH 3/3] infiniband: IB/hns: add Hisilicon RoCE support with bindings Date: Sat, 19 Mar 2016 19:14:34 +0800 Message-ID: <56ED349A.8060806@huawei.com> References: <1457692631-9290-1-git-send-email-oulijun@huawei.com> <1457692631-9290-4-git-send-email-oulijun@huawei.com> <56E2CA90.9020401@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: , , , , , , , , , , , To: Sergei Shtylyov , , , , , , , Return-path: In-Reply-To: <56E2CA90.9020401-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On 2016/3/11 21:39, Sergei Shtylyov wrote: > Hello. > > On 3/11/2016 1:37 PM, Lijun Ou wrote: > >> This submit add binding file and dts file. > > I see no .dts file. > >> >> Signed-off-by: Lijun Ou >> Signed-off-by: Wei Hu(Xavier) >> --- >> .../bindings/infiniband/hisilicon-hns-roce.txt | 68 ++++++++++++++++++++++ >> 1 file changed, 68 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt >> >> diff --git a/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt b/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt >> new file mode 100644 >> index 0000000..8004641 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/infiniband/hisilicon-hns-roce.txt >> @@ -0,0 +1,68 @@ >> +HiSilicon RoCE DT description >> + >> +HiSilicon RoCE engine is a part of network subsystem. >> +It works depending on other part of network wubsytem, such as, gmac and > > Subsystem. > >> +dsa fabric. >> + >> +Additional properties are described here: >> + >> +Required properties: >> +- compatible: Should contain "hisilicon,hns-roce-v1". >> +- reg: Physical base address of the roce driver and >> +length of memory mapped region. >> +- eth-handle: phandle, specifies a reference to a node >> +representing a ethernet device. >> +- dsaf-handle: phandle, specifies a reference to a node >> +representing a dsaf device. >> +- #address-cells: must be 2 >> +- #size-cells: must be 2 >> +Optional properties: >> +- dma-coherent: Present if DMA operations are coherent. >> +- interrupt-parent: the interrupt parent of this device. >> +- interrupts: should contain 32 completion event irq,1 async event irq >> +and 1 event overflow irq. > > The "interrupt-names" prop is strongly desired with some many IRQs. > >> +Example: >> + rocee@0xc4000000 { > > The node names should be generic, not implementation specific. > > [...] > > MBR, Sergei > > > . > Hi Sergei Shtylyov , thanks for reviewing I have modified it, I will send a new patch at soon thanks Lijun Ou -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html