netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yisen Zhuang <Yisen.zhuang@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <yankejian@huawei.com>, <huangdaode@hisilicon.com>,
	<salil.mehta@huawei.com>, <lisheng011@huawei.com>,
	<lipeng321@huawei.com>, <liguozhu@huawei.com>, <arnd@arndb.de>,
	<xieqianqian@huawei.com>, <andrew@lunn.ch>, <ivecera@redhat.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linuxarm@huawei.com>
Subject: Re: [PATCH net 03/10] net: hns: add uc match for debug ports
Date: Tue, 22 Mar 2016 09:03:12 +0800	[thread overview]
Message-ID: <56F099D0.3070102@huawei.com> (raw)
In-Reply-To: <20160321.114055.845640249977716034.davem@davemloft.net>



在 2016/3/21 23:40, David Miller 写道:
> From: Yisen Zhuang <Yisen.Zhuang@huawei.com>
> Date: Mon, 21 Mar 2016 19:06:34 +0800
> 
>> +	(void)hns_mac_set_promisc(mac_cb, (u8)!!en);
> 
> This cast to void is unnecssary.

I think hns_mac_set_promisc don't need to return a value， so i will fix it in next submit.

Thanks

> 
>> +static void hns_gmac_set_uc_match(void *mac_drv, u16 en)
>> +{
>> +	struct mac_driver *drv = (struct mac_driver *)mac_drv;
> 
> Casts from void pointers are unnecessary.

Will fix it in next submit.

Thanks

> 
>> +{
>> +	struct mac_driver *drv = (struct mac_driver *)mac_drv;
> 
> Likewise.

Will fix it in next submit.

Thanks,

Yisen

> 
> .
> 

  reply	other threads:[~2016-03-22  1:03 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-21 11:06 [PATCH net 00/10] net: hns: bugs fixed for hns Yisen Zhuang
2016-03-21 11:06 ` [PATCH net 01/10] net: hns: bug fix about ping6 Yisen Zhuang
2016-03-21 15:39   ` David Miller
2016-03-22  0:46     ` Yisen Zhuang
2016-03-21 11:06 ` [PATCH net 02/10] net: hns: fixed portid bug in sending manage pkt Yisen Zhuang
2016-03-21 11:06 ` [PATCH net 03/10] net: hns: add uc match for debug ports Yisen Zhuang
2016-03-21 15:40   ` David Miller
2016-03-22  1:03     ` Yisen Zhuang [this message]
2016-03-21 11:06 ` [PATCH net 04/10] net: hns: fixed the bug about GMACs mac setting Yisen Zhuang
2016-03-21 11:06 ` [PATCH net 05/10] net: hns: set xge statistic reg as read only Yisen Zhuang
2016-03-21 11:06 ` [PATCH net 06/10] net: hns: fix return value of the function about rss Yisen Zhuang
2016-03-21 15:42   ` David Miller
2016-03-22  1:16     ` Yisen Zhuang
2016-03-21 11:06 ` [PATCH net 07/10] net: hns: fixes a bug of RSS Yisen Zhuang
2016-03-21 11:06 ` [PATCH net 08/10] net: hns: fix the bug about mtu setting Yisen Zhuang
2016-03-21 11:06 ` [PATCH net 09/10] net: hns: adds limitation for debug port mtu Yisen Zhuang
2016-03-21 14:17   ` Sergei Shtylyov
2016-03-22  1:19     ` Yisen Zhuang
2016-03-21 11:06 ` [PATCH net 10/10] net: hns: bug fix about the overflow of mss Yisen Zhuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F099D0.3070102@huawei.com \
    --to=yisen.zhuang@huawei.com \
    --cc=andrew@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=huangdaode@hisilicon.com \
    --cc=ivecera@redhat.com \
    --cc=liguozhu@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=lipeng321@huawei.com \
    --cc=lisheng011@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=salil.mehta@huawei.com \
    --cc=xieqianqian@huawei.com \
    --cc=yankejian@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).