From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Armstrong Subject: Re: [PATCH 1/1] net: macb: remove BUG_ON() and reset the queue to handle RX errors Date: Thu, 24 Mar 2016 15:53:16 +0100 Message-ID: <56F3FF5C.6030000@baylibre.com> References: <1458830232-6159-1-git-send-email-cyrille.pitchen@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org To: Cyrille Pitchen , nicolas.ferre@atmel.com, davem@davemloft.net, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, soren.brinkmann@xilinx.com Return-path: Received: from mail-wm0-f52.google.com ([74.125.82.52]:33624 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757895AbcCXOxY (ORCPT ); Thu, 24 Mar 2016 10:53:24 -0400 Received: by mail-wm0-f52.google.com with SMTP id l68so278366745wml.0 for ; Thu, 24 Mar 2016 07:53:23 -0700 (PDT) In-Reply-To: <1458830232-6159-1-git-send-email-cyrille.pitchen@atmel.com> Sender: netdev-owner@vger.kernel.org List-ID: On 03/24/2016 03:37 PM, Cyrille Pitchen wrote: > This patch removes two BUG_ON() used to notify about RX queue corruptions > on macb (not gem) hardware without actually handling the error. > > The new code skips corrupted frames but still processes faultless frames. > Then it resets the RX queue before restarting the reception from a clean > state. > > This patch is a rework of an older patch proposed by Neil Armstrong: > http://patchwork.ozlabs.org/patch/371525/ > > Signed-off-by: Cyrille Pitchen > --- > drivers/net/ethernet/cadence/macb.c | 59 ++++++++++++++++++++++++++++++------- > 1 file changed, 49 insertions(+), 10 deletions(-) Hi Cyrille, Thanks for the rework, we solved this situation by moving the descriptors to an internal RAM with lower latencies, we suspected our AHB-AXI bridge + DDR Controller to delay the descriptor writes while the interrupt was handled in the meantime. But the error case was still not handled. Acked-by: Neil Armstrong Thanks, Neil