From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Greear Subject: Re: veth regression with =?UTF-8?B?ImRvbuKAmXQgbW9kaWZ5IGlwX3N1bQ==?= =?UTF-8?B?bWVkOyBkb2luZyBzbyB0cmVhdHMgcGFja2V0cyB3aXRoIGJhZCBjaGVja3N1bXM=?= =?UTF-8?B?IGFzIGdvb2QuIg==?= Date: Thu, 24 Mar 2016 22:13:33 -0700 Message-ID: <56F4C8FD.7030907@candelatech.com> References: <56F463D6.7080406@candelatech.com> <56F4810A.9060904@candelatech.com> <56F49036.8050902@candelatech.com> <56F490B2.3090603@candelatech.com> <56F4BFF1.8010806@candelatech.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Vijay Pandurangan , netdev , Evan Jones , Cong Wang To: Cong Wang Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:58607 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750836AbcCYFNg (ORCPT ); Fri, 25 Mar 2016 01:13:36 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 03/24/2016 10:06 PM, Cong Wang wrote: > On Thu, Mar 24, 2016 at 9:34 PM, Ben Greear wrote: >> >> >> On 03/24/2016 06:44 PM, Vijay Pandurangan wrote: >>> >>> Oops, I think my last email didn't go through due to an inadvertent >>> html attachment from my phone mail client. >>> >>> Can you send us a copy of a packet you're sending and/or confirm that >>> the IP and UDP4 checksums are set correctly in the packet? >>> >>> If those are set right, I think we need to read through the networking >>> code again to see why this is broken... >> >> >> Wireshark decodes the packet as having no checksum errors. >> >> I think the contents of the packet is correct, but the 'ip_summed' >> field is set incorrectly to 'NONE' when transmitting on a raw packet >> socket. > > Yeah, these bugs are all due to the different interpretations of > ip_summed on TX path and RX path. I think the following patch > should work, if the comments don't mislead me. Could you give > it a try? > > For the long term, we need to unify the meaning of ip_summed > on TX path and RX path, or at least translate it in skb_scrub_packet(). I can test this tomorrow, but I think it will not work. I'm not sending raw IP frames, I'm sending full ethernet frames. Socket is PF_PACKET, SOCK_RAW. Your patch may still be useful for others though? Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com