From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: John Keeping <john@metanate.com>
Cc: Gabriel Fernandez <gabriel.fernandez@linaro.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] stmmac: Fix phy without MDIO subnode
Date: Fri, 25 Mar 2016 09:42:30 +0100 [thread overview]
Message-ID: <56F4F9F6.8070103@st.com> (raw)
In-Reply-To: <20160324170119.28d54ed5.john@metanate.com>
On 3/24/2016 6:01 PM, John Keeping wrote:
> On Thu, 24 Mar 2016 13:56:02 +0100, Giuseppe CAVALLARO wrote:
>
>> This should be fixed by some work done some days
>> ago and not yet committed.
>>
>> Pls see "stmmac: MDIO fixes" patch-set and let me know
>> if ok on your side.
>
> Yes, that works for me.
thx John for having tested it on your side.
peppe
>
>
> Thanks,
> John
>
>> On 3/24/2016 11:56 AM, John Keeping wrote:
>>> Since commit 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found'
>>> regression") we no longer allocate mdio_bus_data unless there is a MDIO
>>> subnode. This breaks the ethernet on the Radxa Rock2 (using
>>> rk3288-rock2-square.dts) which does not have an MDIO subnode.
>>>
>>> That commit was correct that the phy_bus_name test is unhelpful since we
>>> allocate "plat" in the same function and never set phy_bus_name so let's
>>> just drop the test which restores the previous behaviour.
>>>
>>> Fixes: 88f8b1bb41c6 ("stmmac: Fix 'eth0: No PHY found' regression")
>>> Signed-off-by: John Keeping <john@metanate.com>
>>> ---
>>> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>>> index dcbd2a1..e0fa060 100644
>>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>>> @@ -189,7 +189,7 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
>>> if (of_property_read_u32(np, "snps,phy-addr", &plat->phy_addr) == 0)
>>> dev_warn(&pdev->dev, "snps,phy-addr property is deprecated\n");
>>>
>>> - if ((plat->phy_node && !of_phy_is_fixed_link(np)) || !plat->mdio_node)
>>> + if ((plat->phy_node && !of_phy_is_fixed_link(np)))
>>> plat->mdio_bus_data = NULL;
>>> else
>>> plat->mdio_bus_data =
>>>
>>
>
>
next prev parent reply other threads:[~2016-03-25 8:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 10:56 [PATCH] stmmac: Fix phy without MDIO subnode John Keeping
2016-03-24 12:56 ` Giuseppe CAVALLARO
2016-03-24 17:01 ` John Keeping
2016-03-25 8:42 ` Giuseppe CAVALLARO [this message]
2016-03-30 18:22 ` Robert Gadsdon
2016-03-31 7:40 ` Giuseppe CAVALLARO
2016-03-31 17:30 ` Robert Gadsdon
2016-03-24 13:00 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F4F9F6.8070103@st.com \
--to=peppe.cavallaro@st.com \
--cc=gabriel.fernandez@linaro.org \
--cc=john@metanate.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).