From: Ben Greear <greearb@candelatech.com>
To: David Miller <davem@davemloft.net>
Cc: xiyou.wangcong@gmail.com, vijayp@vijayp.ca,
netdev@vger.kernel.org, ej@evanjones.ca, cwang@twopensource.com
Subject: Re: veth regression with "don’t modify ip_summed; doing so treats packets with bad checksums as good."
Date: Fri, 25 Mar 2016 10:14:46 -0700 [thread overview]
Message-ID: <56F57206.5000701@candelatech.com> (raw)
In-Reply-To: <20160325.124427.273071525698476869.davem@davemloft.net>
On 03/25/2016 09:44 AM, David Miller wrote:
> From: Ben Greear <greearb@candelatech.com>
> Date: Fri, 25 Mar 2016 09:10:58 -0700
>
>> I am suspicious that this will break at least some drivers. I
>> grepped around for ip_summed, and found this, for instance:
>>
>> davicom/dm9000.c
>>
>> /* The DM9000 is not smart enough to leave fragmented packets
>
> An really old (circa 1997), not-oft-used, driver such as this is not
> the place to be looking for correct usage of skb->ip_summed semantics.
>
> I would never use whatever a driver like this does influence whether I
> apply a bug fix or not.
Point is, it took me 5 minutes to find that, and I did not look hard at many
other drivers. e1000e and igb appear to be fine, and maybe the rest of them
are too. Lord knows what other strange setups might be effected by the
ip_summed change.
Anyway, you know the stack and drivers better than me, so if you think Cong's
patch is valid, then I'll test it and make sure it works in my setups at least.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2016-03-25 17:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 22:01 veth regression with "don’t modify ip_summed; doing so treats packets with bad checksums as good." Ben Greear
[not found] ` <CAKUBDd91rR7QTwCO6L6ZfRe4fuHw0L5+Zi7qm0uF018dwVGCLg@mail.gmail.com>
2016-03-24 22:57 ` Ben Greear
2016-03-24 23:56 ` Cong Wang
2016-03-25 0:06 ` Ben Greear
2016-03-25 1:11 ` Ben Greear
2016-03-25 1:13 ` Ben Greear
2016-03-25 1:44 ` Vijay Pandurangan
2016-03-25 4:34 ` Ben Greear
2016-03-25 4:41 ` Vijay Pandurangan
2016-03-25 4:45 ` Vijay Pandurangan
2016-03-25 5:07 ` Ben Greear
2016-03-25 5:24 ` Vijay Pandurangan
2016-03-25 14:35 ` Ben Greear
2016-03-25 21:51 ` Vijay Pandurangan
2016-03-25 5:06 ` Cong Wang
2016-03-25 5:13 ` Ben Greear
2016-03-25 5:33 ` Cong Wang
2016-03-25 16:10 ` Ben Greear
2016-03-25 16:32 ` Cong Wang
2016-03-25 16:45 ` David Miller
2016-03-25 16:44 ` David Miller
2016-03-25 17:14 ` Ben Greear [this message]
2016-03-25 19:00 ` David Miller
2016-03-25 20:56 ` Ben Greear
2016-03-25 21:59 ` Vijay Pandurangan
2016-03-25 22:23 ` Ben Greear
2016-03-25 23:03 ` Vijay Pandurangan
2016-03-25 23:46 ` Ben Greear
2016-04-07 15:11 ` Vijay Pandurangan
2016-04-07 18:32 ` Ben Greear
2016-03-25 22:23 ` Cong Wang
2016-03-25 22:16 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F57206.5000701@candelatech.com \
--to=greearb@candelatech.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=ej@evanjones.ca \
--cc=netdev@vger.kernel.org \
--cc=vijayp@vijayp.ca \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).