From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Bhaskar Jupudi <njupudi@ucsc.edu>,
davem@davemloft.net, igal.liberman@freescale.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers : Remove unnecessary void pointer conversions
Date: Sun, 27 Mar 2016 14:46:04 +0300 [thread overview]
Message-ID: <56F7C7FC.9020001@cogentembedded.com> (raw)
In-Reply-To: <1459050140-14621-1-git-send-email-njupudi@ucsc.edu>
Hello.
On 3/27/2016 6:42 AM, Bhaskar Jupudi wrote:
> Explicit void pointer conversion is unnecessary
> because the conversions to and from a void pointer
> are always implicit in 'C'. Changed two instances
> of such conversions.
>
>
> Signed-off-by: Bhaskar Jupudi <njupudi@ucsc.edu>
> ---
> This patch is based on Kernel Janitors To-Do list
>
> drivers/net/ethernet/freescale/fman/fman.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c
> index 623aa1c..8719f7b 100644
> --- a/drivers/net/ethernet/freescale/fman/fman.c
> +++ b/drivers/net/ethernet/freescale/fman/fman.c
> @@ -2668,7 +2668,7 @@ static struct fman *read_dts_node(struct platform_device *of_dev)
>
> fm_node = of_node_get(of_dev->dev.of_node);
>
> - u32_prop = (const u32 *)of_get_property(fm_node, "cell-index", &lenp);
> + u32_prop = of_get_property(fm_node, "cell-index", &lenp);
This function returns a pointer to big-endian data, no?
> if (!u32_prop) {
> dev_err(&of_dev->dev, "%s: of_get_property(%s, cell-index) failed\n",
> __func__, fm_node->full_name);
> @@ -2724,7 +2724,7 @@ static struct fman *read_dts_node(struct platform_device *of_dev)
> /* Rounding to MHz */
> fman->dts_params.clk_freq = DIV_ROUND_UP(clk_rate, 1000000);
>
> - u32_prop = (const u32 *)of_get_property(fm_node,
> + u32_prop = of_get_property(fm_node,
Same here...
> "fsl,qman-channel-range",
> &lenp);
Please re-align these continuation lines.
[...]
MBR, Sergei
prev parent reply other threads:[~2016-03-27 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 3:42 [PATCH] drivers : Remove unnecessary void pointer conversions Bhaskar Jupudi
2016-03-27 5:49 ` Joe Perches
2016-03-27 11:46 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F7C7FC.9020001@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=igal.liberman@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=njupudi@ucsc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).