From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH 1/4] samples/bpf: Fix build breakage with map_perf_test_user.c Date: Thu, 31 Mar 2016 10:43:18 -0700 Message-ID: <56FD61B6.9000102@fb.com> References: <922f95fb5d16686367a66d2d4bd176149a87e9ad.1459423412.git.naveen.n.rao@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "David S . Miller" , Ananth N Mavinakayanahalli , Michael Ellerman , Daniel Borkmann , To: "Naveen N. Rao" , , Return-path: In-Reply-To: <922f95fb5d16686367a66d2d4bd176149a87e9ad.1459423412.git.naveen.n.rao@linux.vnet.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 3/31/16 4:25 AM, Naveen N. Rao wrote: > Building BPF samples is failing with the below error: > > samples/bpf/map_perf_test_user.c: In function =E2=80=98main=E2=80=99: > samples/bpf/map_perf_test_user.c:134:9: error: variable =E2=80=98r=E2= =80=99 has > initializer but incomplete type > struct rlimit r =3D {RLIM_INFINITY, RLIM_INFINITY}; > ^ > Fix this by including the necessary header file. > > Cc: Alexei Starovoitov > Cc: David S. Miller > Cc: Ananth N Mavinakayanahalli > Cc: Michael Ellerman > Signed-off-by: Naveen N. Rao > --- > samples/bpf/map_perf_test_user.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/samples/bpf/map_perf_test_user.c b/samples/bpf/map_perf_= test_user.c > index 95af56e..3147377 100644 > --- a/samples/bpf/map_perf_test_user.c > +++ b/samples/bpf/map_perf_test_user.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include "libbpf.h" > #include "bpf_load.h" It's failing this way on powerpc? Odd. Such hidden header dependency was always puzzling to me. Anyway: Acked-by: Alexei Starovoitov I'm assuming you want this set to go via 'net' tree, so please resubmit with [PATCH net 1/4] subjects and cc netdev. Reviewing your other patches...