[PATCH 2.6] eepro100: remove ID for 82556

[PATCH 2.6] eepro100: remove ID for 82556

[Scott Feldman]

82556 support doesn't work with eepro100, so this removes the ID
(0x1228) for 82556.  See this thread for more info:

http://marc.theaimsgroup.com/?l=linux-kernel&m=110726223221165&w=2

Signed-off-by: Scott Feldman <sfeldma@pobox.com>

--- linux-2.4.28-rc1/drivers/net/eepro100.c.orig	2005-02-01 10:58:56.878906632 -0800
+++ linux-2.4.28-rc1/drivers/net/eepro100.c	2005-02-01 10:59:10.479838976 -0800
@@ -2395,7 +2395,6 @@
 	{ PCI_VENDOR_ID_INTEL, 0x1050, PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, 0x1059, PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, 0x1227, PCI_ANY_ID, PCI_ANY_ID, },
-	{ PCI_VENDOR_ID_INTEL, 0x1228, PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, 0x2449, PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, 0x2459, PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, 0x245D, PCI_ANY_ID, PCI_ANY_ID, },

Re: [PATCH 2.6] eepro100: remove ID for 82556

[Jeff Garzik]

Scott Feldman wrote:
> 82556 support doesn't work with eepro100, so this removes the ID
> (0x1228) for 82556.  See this thread for more info:
> 
> http://marc.theaimsgroup.com/?l=linux-kernel&m=110726223221165&w=2
> 
> Signed-off-by: Scott Feldman <sfeldma@pobox.com>

I see the thread, but I still worry about removing the id in your patch, 
since the poster in the thread says that they had to -add- an ID to both 
e100 and eepro100 in order to perform their test.

Has anyone with this PCI ID actually confirmed that eepro100 does not 
work for them?

	Jeff

Re: [PATCH 2.6] eepro100: remove ID for 82556

[Meelis Roos]

JG> I see the thread, but I still worry about removing the id in your patch, 
JG> since the poster in the thread says that they had to -add- an ID to both 
JG> e100 and eepro100 in order to perform their test.
JG> 
JG> Has anyone with this PCI ID actually confirmed that eepro100 does not 
JG> work for them?

I added the PCI ID only to e100, it was already present in eepro100.

Neither unmodified eepro100 nor pci-id-added e100 worked with this
chip so IMHO it's safe to remove this PCI ID from eepro100 too.

-- 
Meelis Roos

Re: [PATCH 2.6] eepro100: remove ID for 82556

[John Ronciak]

The 82556 is not support by the e100 driver.  It is a different
architecture than the one started with the 82557 thru the current
generation of PRO/100 controllers.


On Sat, 19 Feb 2005 10:08:02 +0200, Meelis Roos <mroos@linux.ee> wrote:
> JG> I see the thread, but I still worry about removing the id in your patch,
> JG> since the poster in the thread says that they had to -add- an ID to both
> JG> e100 and eepro100 in order to perform their test.
> JG>
> JG> Has anyone with this PCI ID actually confirmed that eepro100 does not
> JG> work for them?
> 
> I added the PCI ID only to e100, it was already present in eepro100.
> 
> Neither unmodified eepro100 nor pci-id-added e100 worked with this
> chip so IMHO it's safe to remove this PCI ID from eepro100 too.
> 
> --
> Meelis Roos
> 
> 


-- 
Cheers,
John