From: Saeed Mahameed <saeedm@mellanox.com>
To: "alexei.starovoitov@gmail.com" <alexei.starovoitov@gmail.com>
Cc: Eli Cohen <eli@mellanox.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Paul Blakey <paulb@mellanox.com>
Subject: Re: [net-next 01/12] net/mlx5: E-Switch, add ingress rate support
Date: Fri, 2 Aug 2019 20:48:06 +0000 [thread overview]
Message-ID: <56b51e1c9f960498ee698e412bfab278a7e79c47.camel@mellanox.com> (raw)
In-Reply-To: <20190802194429.m34bpvf5hzgkop4g@ast-mbp.dhcp.thefacebook.com>
On Fri, 2019-08-02 at 12:44 -0700, Alexei Starovoitov wrote:
> On Fri, Aug 02, 2019 at 07:22:21PM +0000, Saeed Mahameed wrote:
> > On Fri, 2019-08-02 at 10:37 -0700, Alexei Starovoitov wrote:
> > > On Thu, Aug 1, 2019 at 6:30 PM Saeed Mahameed <
> > > saeedm@mellanox.com>
> > > wrote:
> > > > From: Eli Cohen <eli@mellanox.com>
> > > >
> > > > Use the scheduling elements to implement ingress rate limiter
> > > > on an
> > > > eswitch ports ingress traffic. Since the ingress of eswitch
> > > > port is
> > > > the
> > > > egress of VF port, we control eswitch ingress by controlling VF
> > > > egress.
> > >
> > > Looks like the patch is only passing args to firmware which is
> > > doing
> > > the magic.
> > > Can you please describe what is the algorithm there?
> > > Is it configurable?
> >
> > Hi Alexei,
> >
> > I am not sure how much details you are looking for, but let me
> > share
> > some of what i know:
> >
> > From a previous submission for legacy mode sriov vf bw limit, where
> > we
> > introduced the FW configuration API and the legacy sriov use case:
> > https://patchwork.kernel.org/patch/9404655/
> >
> > So basically the algorithm is Deficit Weighted Round Robin (DWRR)
> > between the agents, we can control BW allocation/weight of each
> > agent
> > (vf vport).
>
> commit log of this patch says nothing about DWRR.
it says it uses the "scheduling elements ingress rate limiter" which
automatically translates to DWRR, this is basic knowledge for mlx5
developers, and it is clear in the commit message when the FW API was
introduced.
> It is also not using any of the api that were provided by that
> earlier patch.
It is using the api:
mlx5e_tc_configure_matchall => apply_police_params =>
mlx5_esw_modify_vport_rate => mlx5_modify_scheduling_element_cmd()..
> what is going on?
>
can you please clarify what is bothering you ? we can fix it if
necessary.
Thanks,
Saeed.
next prev parent reply other threads:[~2019-08-02 20:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 19:56 [pull request][net-next 00/12] Mellanox, mlx5 updates 2019-08-01 Saeed Mahameed
2019-08-01 19:56 ` [net-next 01/12] net/mlx5: E-Switch, add ingress rate support Saeed Mahameed
2019-08-02 17:37 ` Alexei Starovoitov
2019-08-02 19:22 ` Saeed Mahameed
2019-08-02 19:44 ` Alexei Starovoitov
2019-08-02 20:48 ` Saeed Mahameed [this message]
2019-08-01 19:56 ` [net-next 02/12] net/mlx5: Add flow counter bulk infrastructure Saeed Mahameed
2019-08-01 19:56 ` [net-next 03/12] net/mlx5: Add flow counter pool Saeed Mahameed
2019-08-01 19:56 ` [net-next 04/12] net/mlx5e: Tx, Strict the room needed for SQ edge NOPs Saeed Mahameed
2019-08-01 19:56 ` [net-next 05/12] net/mlx5e: XDP, Close TX MPWQE session when no room for inline packet left Saeed Mahameed
2019-08-01 19:57 ` [net-next 06/12] net/mlx5e: XDP, Slight enhancement for WQE fetch function Saeed Mahameed
2019-08-01 19:57 ` [net-next 07/12] net/mlx5e: Tx, Soften inline mode VLAN dependencies Saeed Mahameed
2019-08-01 19:57 ` [net-next 08/12] net/mlx5e: Rx, checksum handling refactoring Saeed Mahameed
2019-08-01 19:57 ` [net-next 09/12] net/mlx5e: Fix mlx5e_tx_reporter_create return value Saeed Mahameed
2019-08-01 19:57 ` [net-next 10/12] net/mlx5e: Set tx reporter only on successful creation Saeed Mahameed
2019-08-01 19:57 ` [net-next 11/12] net/mlx5e: TX reporter cleanup Saeed Mahameed
2019-08-01 19:57 ` [net-next 12/12] net/mlx5e: Allow dropping specific tunnel packets Saeed Mahameed
2019-08-05 17:50 ` [pull request][net-next 00/12] Mellanox, mlx5 updates 2019-08-01 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56b51e1c9f960498ee698e412bfab278a7e79c47.camel@mellanox.com \
--to=saeedm@mellanox.com \
--cc=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=eli@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=paulb@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).