From: Saeed Mahameed <saeed@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Vlad Buslov <vladbu@nvidia.com>, Roi Dayan <roid@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>
Subject: Re: [net-next 16/17] net/mlx5: Bridge, allow merged eswitch connectivity
Date: Mon, 16 Aug 2021 16:23:14 -0700 [thread overview]
Message-ID: <56cd4ba05d5393af8a2d4490d73e34279d0bf1ac.camel@kernel.org> (raw)
In-Reply-To: <20210816153826.4b7e4330@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Mon, 2021-08-16 at 15:38 -0700, Jakub Kicinski wrote:
> On Mon, 16 Aug 2021 14:18:46 -0700 Saeed Mahameed wrote:
> > From: Vlad Buslov <vladbu@nvidia.com>
> >
> > Allow connectivity between representors of different eswitch
> > instances that
> > are attached to same bridge when merged_eswitch capability is
> > enabled. Add
> > ports of peer eswitch to bridge instance and mark them with
> > MLX5_ESW_BRIDGE_PORT_FLAG_PEER. Mark FDBs offloaded on peer ports
> > with
> > MLX5_ESW_BRIDGE_FLAG_PEER flag. Such FDBs can only be aged out on
> > their
> > local eswitch instance, which then sends
> > SWITCHDEV_FDB_DEL_TO_BRIDGE event.
> > Listen to the event on mlx5 bridge implementation and delete peer
> > FDBs in
> > event handler.
> >
> > Signed-off-by: Vlad Buslov <vladbu@nvidia.com>
> > Reviewed-by: Roi Dayan <roid@nvidia.com>
> > Reviewed-by: Mark Bloch <mbloch@nvidia.com>
> > Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
>
>
> drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c: In function
> ‘mlx5_esw_bridge_switchdev_fdb_event_work’:
> drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c:286:21:
> warning: variable ‘priv’ set but not used [-Wunused-but-set-variable]
> 286 | struct mlx5e_priv *priv;
> | ^~~~
Missing kconfig in our CI.
Thanks for the reprot, handled in V2.
next prev parent reply other threads:[~2021-08-16 23:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 21:18 [pull request][net-next 00/17] mlx5 updates 2021-08-16 Saeed Mahameed
2021-08-16 21:18 ` [net-next 01/17] net/mlx5e: Do not try enable RSS when resetting indir table Saeed Mahameed
2021-08-16 21:18 ` [net-next 02/17] net/mlx5e: Introduce TIR create/destroy API in rx_res Saeed Mahameed
2021-08-16 21:18 ` [net-next 03/17] net/mlx5e: Introduce abstraction of RSS context Saeed Mahameed
2021-08-16 21:18 ` [net-next 04/17] net/mlx5e: Convert RSS to a dedicated object Saeed Mahameed
2021-08-16 21:18 ` [net-next 05/17] net/mlx5e: Dynamically allocate TIRs in RSS contexts Saeed Mahameed
2021-08-16 21:18 ` [net-next 06/17] net/mlx5e: Support multiple " Saeed Mahameed
2021-08-16 21:18 ` [net-next 07/17] net/mlx5e: Support flow classification into " Saeed Mahameed
2021-08-16 21:18 ` [net-next 08/17] net/mlx5e: Abstract MQPRIO params Saeed Mahameed
2021-08-16 21:18 ` [net-next 09/17] net/mlx5e: Maintain MQPRIO mode parameter Saeed Mahameed
2021-08-16 21:18 ` [net-next 10/17] net/mlx5e: Handle errors of netdev_set_num_tc() Saeed Mahameed
2021-08-16 21:18 ` [net-next 11/17] net/mlx5e: Support MQPRIO channel mode Saeed Mahameed
2021-08-16 21:18 ` [net-next 12/17] net/mlx5: Bridge, release bridge in same function where it is taken Saeed Mahameed
2021-08-16 21:18 ` [net-next 13/17] net/mlx5: Bridge, obtain core device from eswitch instead of priv Saeed Mahameed
2021-08-16 21:18 ` [net-next 14/17] net/mlx5: Bridge, identify port by vport_num+esw_owner_vhca_id pair Saeed Mahameed
2021-08-16 21:18 ` [net-next 15/17] net/mlx5: Bridge, extract FDB delete notification to function Saeed Mahameed
2021-08-16 21:18 ` [net-next 16/17] net/mlx5: Bridge, allow merged eswitch connectivity Saeed Mahameed
2021-08-16 22:38 ` Jakub Kicinski
2021-08-16 23:23 ` Saeed Mahameed [this message]
2021-08-16 21:18 ` [net-next 17/17] net/mlx5: Bridge, support LAG Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56cd4ba05d5393af8a2d4490d73e34279d0bf1ac.camel@kernel.org \
--to=saeed@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=roid@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=vladbu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).