From: Soeren Moch <smoch@web.de>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
Heiko Stuebner <heiko@sntech.de>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
Wright Feng <wright.feng@cypress.com>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH v2 5/9] brcmfmac: add support for BCM4359 SDIO chipset
Date: Thu, 12 Dec 2019 02:02:27 +0100 [thread overview]
Message-ID: <56de6321-bfc5-a66c-23c0-8928221c2a7f@web.de> (raw)
In-Reply-To: <20191211235253.2539-6-smoch@web.de>
Hi Ulf,
This patch is part of a series [1] to add support for the BCM4359
chipset with SDIO interface to the brcmfmac wireless network driver.
I just realized that this patch touches
include/linux/mmc/sdio_ids.h
and therefore I need an Ack from MMC folks. Can you please look at this?
Thanks and sorry for not including you in the original patch series
submission,
Soeren
[1] https://lkml.org/lkml/2019/12/11/1958
On 12.12.19 00:52, Soeren Moch wrote:
> BCM4359 is a 2x2 802.11 abgn+ac Dual-Band HT80 combo chip and it
> supports Real Simultaneous Dual Band feature.
>
> Based on a similar patch by: Wright Feng <wright.feng@cypress.com>
>
> Signed-off-by: Soeren Moch <smoch@web.de>
> ---
> changes in v2:
> - add SDIO_DEVICE_ID_CYPRESS_89359 as requested
> by Chi-Hsien Lin <chi-hsien.lin@cypress.com>
>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Arend van Spriel <arend.vanspriel@broadcom.com>
> Cc: Franky Lin <franky.lin@broadcom.com>
> Cc: Hante Meuleman <hante.meuleman@broadcom.com>
> Cc: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
> Cc: Wright Feng <wright.feng@cypress.com>
> Cc: linux-wireless@vger.kernel.org
> Cc: brcm80211-dev-list.pdl@broadcom.com
> Cc: brcm80211-dev-list@cypress.com
> Cc: netdev@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 ++
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c | 1 +
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 ++
> include/linux/mmc/sdio_ids.h | 2 ++
> 4 files changed, 7 insertions(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> index 68baf0189305..f4c53ab46058 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
> @@ -973,8 +973,10 @@ static const struct sdio_device_id brcmf_sdmmc_ids[] = {
> BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_43455),
> BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_4354),
> BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_4356),
> + BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_BROADCOM_4359),
> BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_CYPRESS_4373),
> BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_CYPRESS_43012),
> + BRCMF_SDIO_DEVICE(SDIO_DEVICE_ID_CYPRESS_89359),
> { /* end: all zeroes */ }
> };
> MODULE_DEVICE_TABLE(sdio, brcmf_sdmmc_ids);
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c
> index baf72e3984fc..282d0bc14e8e 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c
> @@ -1408,6 +1408,7 @@ bool brcmf_chip_sr_capable(struct brcmf_chip *pub)
> addr = CORE_CC_REG(base, sr_control0);
> reg = chip->ops->read32(chip->ctx, addr);
> return (reg & CC_SR_CTL0_ENABLE_MASK) != 0;
> + case BRCM_CC_4359_CHIP_ID:
> case CY_CC_43012_CHIP_ID:
> addr = CORE_CC_REG(pmu->base, retention_ctl);
> reg = chip->ops->read32(chip->ctx, addr);
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> index 21e535072f3f..c4012ed58b9c 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
> @@ -616,6 +616,7 @@ BRCMF_FW_DEF(43455, "brcmfmac43455-sdio");
> BRCMF_FW_DEF(43456, "brcmfmac43456-sdio");
> BRCMF_FW_DEF(4354, "brcmfmac4354-sdio");
> BRCMF_FW_DEF(4356, "brcmfmac4356-sdio");
> +BRCMF_FW_DEF(4359, "brcmfmac4359-sdio");
> BRCMF_FW_DEF(4373, "brcmfmac4373-sdio");
> BRCMF_FW_DEF(43012, "brcmfmac43012-sdio");
>
> @@ -638,6 +639,7 @@ static const struct brcmf_firmware_mapping brcmf_sdio_fwnames[] = {
> BRCMF_FW_ENTRY(BRCM_CC_4345_CHIP_ID, 0xFFFFFDC0, 43455),
> BRCMF_FW_ENTRY(BRCM_CC_4354_CHIP_ID, 0xFFFFFFFF, 4354),
> BRCMF_FW_ENTRY(BRCM_CC_4356_CHIP_ID, 0xFFFFFFFF, 4356),
> + BRCMF_FW_ENTRY(BRCM_CC_4359_CHIP_ID, 0xFFFFFFFF, 4359),
> BRCMF_FW_ENTRY(CY_CC_4373_CHIP_ID, 0xFFFFFFFF, 4373),
> BRCMF_FW_ENTRY(CY_CC_43012_CHIP_ID, 0xFFFFFFFF, 43012)
> };
> diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
> index 08b25c02b5a1..2e9a6e4634eb 100644
> --- a/include/linux/mmc/sdio_ids.h
> +++ b/include/linux/mmc/sdio_ids.h
> @@ -41,8 +41,10 @@
> #define SDIO_DEVICE_ID_BROADCOM_43455 0xa9bf
> #define SDIO_DEVICE_ID_BROADCOM_4354 0x4354
> #define SDIO_DEVICE_ID_BROADCOM_4356 0x4356
> +#define SDIO_DEVICE_ID_BROADCOM_4359 0x4359
> #define SDIO_DEVICE_ID_CYPRESS_4373 0x4373
> #define SDIO_DEVICE_ID_CYPRESS_43012 43012
> +#define SDIO_DEVICE_ID_CYPRESS_89359 0x4355
>
> #define SDIO_VENDOR_ID_INTEL 0x0089
> #define SDIO_DEVICE_ID_INTEL_IWMC3200WIMAX 0x1402
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-12-12 1:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 23:52 [PATCH v2 0/9] brcmfmac: add support for BCM4359 SDIO chipset Soeren Moch
2019-12-11 23:52 ` [PATCH v2 1/9] brcmfmac: reset two D11 cores if chip has two D11 cores Soeren Moch
2019-12-18 19:08 ` Kalle Valo
2019-12-11 23:52 ` [PATCH v2 2/9] brcmfmac: set F2 blocksize and watermark for 4359 Soeren Moch
2019-12-11 23:52 ` [PATCH v2 3/9] brcmfmac: fix rambase for 4359/9 Soeren Moch
2019-12-12 2:07 ` Chi-Hsien Lin
2019-12-11 23:52 ` [PATCH v2 4/9] brcmfmac: make errors when setting roaming parameters non-fatal Soeren Moch
2019-12-11 23:52 ` [PATCH v2 5/9] brcmfmac: add support for BCM4359 SDIO chipset Soeren Moch
2019-12-12 1:02 ` Soeren Moch [this message]
2019-12-12 2:09 ` Chi-Hsien Lin
2019-12-12 8:33 ` Ulf Hansson
2019-12-11 23:52 ` [PATCH v2 6/9] brcmfmac: add RSDB condition when setting interface combinations Soeren Moch
2019-12-11 23:52 ` [PATCH v2 7/9] brcmfmac: not set mbss in vif if firmware does not support MBSS Soeren Moch
2019-12-11 23:52 ` [PATCH v2 8/9] arm64: dts: rockchip: RockPro64: enable wifi module at sdio0 Soeren Moch
2019-12-11 23:52 ` [PATCH v2 9/9] arm64: dts: rockchip: RockPro64: hook up bluetooth at uart0 Soeren Moch
2019-12-12 10:22 ` Robin Murphy
2019-12-12 10:47 ` Soeren Moch
2019-12-12 9:42 ` [PATCH v2 0/9] brcmfmac: add support for BCM4359 SDIO chipset Kalle Valo
[not found] ` <0101016ef97cf6b5-2552a5e4-12de-4616-94d6-b63d9c795ed6-000000@us-west-2.amazonses.com>
2019-12-12 10:59 ` Soeren Moch
2019-12-15 21:24 ` Soeren Moch
2019-12-15 23:43 ` Heiko Stübner
2020-03-13 11:03 ` Chi-Hsien Lin
2020-03-13 13:17 ` Soeren Moch
2020-03-15 7:01 ` Chi-Hsien Lin
2019-12-18 11:55 ` Christian Hewitt
2019-12-18 23:04 ` Soeren Moch
2019-12-22 4:35 ` Christian Hewitt
2019-12-24 9:01 ` Arend Van Spriel
2019-12-24 9:44 ` Christian Hewitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56de6321-bfc5-a66c-23c0-8928221c2a7f@web.de \
--to=smoch@web.de \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=heiko@sntech.de \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).