[PATCH net] drivers: net: ice: fix devlink parameters get without irdma

[PATCH net] drivers: net: ice: fix devlink parameters get without irdma

[Nikolay Aleksandrov]

If CONFIG_IRDMA isn't enabled but there are ice NICs in the system, the
driver will prevent full devlink dev param show dump because its rdma get
callbacks return ENODEV and stop the dump. For example:
 $ devlink dev param show
 pci/0000:82:00.0:
   name msix_vec_per_pf_max type generic
     values:
       cmode driverinit value 2
   name msix_vec_per_pf_min type generic
     values:
       cmode driverinit value 2
 kernel answers: No such device

Returning EOPNOTSUPP allows the dump to continue so we can see all devices'
devlink parameters.

Fixes: c24a65b6a27c ("iidc/ice/irdma: Update IDC to support multiple consumers")
Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
---
 drivers/net/ethernet/intel/ice/devlink/devlink.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink.c b/drivers/net/ethernet/intel/ice/devlink/devlink.c
index 2ef39cc70c21..7de749d3f047 100644
--- a/drivers/net/ethernet/intel/ice/devlink/devlink.c
+++ b/drivers/net/ethernet/intel/ice/devlink/devlink.c
@@ -1360,7 +1360,7 @@ ice_devlink_enable_roce_get(struct devlink *devlink, u32 id,
 
 	cdev = pf->cdev_info;
 	if (!cdev)
-		return -ENODEV;
+		return -EOPNOTSUPP;
 
 	ctx->val.vbool = !!(cdev->rdma_protocol & IIDC_RDMA_PROTOCOL_ROCEV2);
 
@@ -1427,7 +1427,7 @@ ice_devlink_enable_iw_get(struct devlink *devlink, u32 id,
 
 	cdev = pf->cdev_info;
 	if (!cdev)
-		return -ENODEV;
+		return -EOPNOTSUPP;
 
 	ctx->val.vbool = !!(cdev->rdma_protocol & IIDC_RDMA_PROTOCOL_IWARP);
 
-- 
2.47.3

RE: [PATCH net] drivers: net: ice: fix devlink parameters get without irdma

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Nikolay Aleksandrov <nikolay@nvidia.com>
> Sent: Friday, February 13, 2026 9:49 AM
> To: netdev@vger.kernel.org
> Cc: David Ahern <dsahern@kernel.org>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@intel.com>; Andrew Lunn <andrew+netdev@lunn.ch>;
> davem@davemloft.net; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>;
> Loktionov, Aleksandr <aleksandr.loktionov@intel.com>; Greenwalt, Paul
> <paul.greenwalt@intel.com>; Daniel Zahka <daniel.zahka@gmail.com>;
> Michal Swiatkowski <michal.swiatkowski@linux.intel.com>; Ertman, David
> M <david.m.ertman@intel.com>; Mustafa Ismail
> <mustafa.ismail@intel.com>; Shiraz Saleem <shiraz.saleem@intel.com>;
> Nikolova, Tatyana E <tatyana.e.nikolova@intel.com>; intel-wired-
> lan@lists.osuosl.org; Nikolay Aleksandrov <nikolay@nvidia.com>
> Subject: [PATCH net] drivers: net: ice: fix devlink parameters get
> without irdma
> 
> If CONFIG_IRDMA isn't enabled but there are ice NICs in the system,
> the driver will prevent full devlink dev param show dump because its
> rdma get callbacks return ENODEV and stop the dump. For example:
>  $ devlink dev param show
>  pci/0000:82:00.0:
>    name msix_vec_per_pf_max type generic
>      values:
>        cmode driverinit value 2
>    name msix_vec_per_pf_min type generic
>      values:
>        cmode driverinit value 2
>  kernel answers: No such device
> 
> Returning EOPNOTSUPP allows the dump to continue so we can see all
> devices'
> devlink parameters.
> 
> Fixes: c24a65b6a27c ("iidc/ice/irdma: Update IDC to support multiple
> consumers")
> Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
> ---
>  drivers/net/ethernet/intel/ice/devlink/devlink.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink.c
> b/drivers/net/ethernet/intel/ice/devlink/devlink.c
> index 2ef39cc70c21..7de749d3f047 100644
> --- a/drivers/net/ethernet/intel/ice/devlink/devlink.c
> +++ b/drivers/net/ethernet/intel/ice/devlink/devlink.c
> @@ -1360,7 +1360,7 @@ ice_devlink_enable_roce_get(struct devlink
> *devlink, u32 id,
> 
>  	cdev = pf->cdev_info;
>  	if (!cdev)
> -		return -ENODEV;
> +		return -EOPNOTSUPP;
> 
>  	ctx->val.vbool = !!(cdev->rdma_protocol &
> IIDC_RDMA_PROTOCOL_ROCEV2);
> 
> @@ -1427,7 +1427,7 @@ ice_devlink_enable_iw_get(struct devlink
> *devlink, u32 id,
> 
>  	cdev = pf->cdev_info;
>  	if (!cdev)
> -		return -ENODEV;
> +		return -EOPNOTSUPP;
> 
>  	ctx->val.vbool = !!(cdev->rdma_protocol &
> IIDC_RDMA_PROTOCOL_IWARP);
> 
> --
> 2.47.3

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>

Re: [PATCH net] drivers: net: ice: fix devlink parameters get without irdma

[Przemek Kitszel]

On 2/13/26 09:48, Nikolay Aleksandrov wrote:
> If CONFIG_IRDMA isn't enabled but there are ice NICs in the system, the
> driver will prevent full devlink dev param show dump because its rdma get
> callbacks return ENODEV and stop the dump. For example:
>   $ devlink dev param show
>   pci/0000:82:00.0:
>     name msix_vec_per_pf_max type generic
>       values:
>         cmode driverinit value 2
>     name msix_vec_per_pf_min type generic
>       values:
>         cmode driverinit value 2
>   kernel answers: No such device

this issue reproduces even with CONFIG_IRDMA enabled,
but just when there is no irdma in use, so the fix helps
a lot

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Tested-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

> 
> Returning EOPNOTSUPP allows the dump to continue so we can see all devices'
> devlink parameters.
> 
> Fixes: c24a65b6a27c ("iidc/ice/irdma: Update IDC to support multiple consumers")
> Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
> ---
>   drivers/net/ethernet/intel/ice/devlink/devlink.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink.c b/drivers/net/ethernet/intel/ice/devlink/devlink.c
> index 2ef39cc70c21..7de749d3f047 100644
> --- a/drivers/net/ethernet/intel/ice/devlink/devlink.c
> +++ b/drivers/net/ethernet/intel/ice/devlink/devlink.c
> @@ -1360,7 +1360,7 @@ ice_devlink_enable_roce_get(struct devlink *devlink, u32 id,
>   
>   	cdev = pf->cdev_info;
>   	if (!cdev)
> -		return -ENODEV;
> +		return -EOPNOTSUPP;
>   
>   	ctx->val.vbool = !!(cdev->rdma_protocol & IIDC_RDMA_PROTOCOL_ROCEV2);
>   
> @@ -1427,7 +1427,7 @@ ice_devlink_enable_iw_get(struct devlink *devlink, u32 id,
>   
>   	cdev = pf->cdev_info;
>   	if (!cdev)
> -		return -ENODEV;
> +		return -EOPNOTSUPP;
>   
>   	ctx->val.vbool = !!(cdev->rdma_protocol & IIDC_RDMA_PROTOCOL_IWARP);
>   

Re: [PATCH net] drivers: net: ice: fix devlink parameters get without irdma

[David Ahern]

On 2/13/26 1:48 AM, Nikolay Aleksandrov wrote:
> If CONFIG_IRDMA isn't enabled but there are ice NICs in the system, the
> driver will prevent full devlink dev param show dump because its rdma get
> callbacks return ENODEV and stop the dump. For example:
>  $ devlink dev param show
>  pci/0000:82:00.0:
>    name msix_vec_per_pf_max type generic
>      values:
>        cmode driverinit value 2
>    name msix_vec_per_pf_min type generic
>      values:
>        cmode driverinit value 2
>  kernel answers: No such device
> 
> Returning EOPNOTSUPP allows the dump to continue so we can see all devices'
> devlink parameters.
> 
> Fixes: c24a65b6a27c ("iidc/ice/irdma: Update IDC to support multiple consumers")
> Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
> ---
>  drivers/net/ethernet/intel/ice/devlink/devlink.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

This patch was marked as awaiting upstream; I wanted to confirm it is in
Intel's queue or was the expectation for netdev maintainer's to pick it up?

Re: [PATCH net] drivers: net: ice: fix devlink parameters get without irdma

[Kohei Enju]

On Sun, 22 Feb 2026 11:27:30 -0700, David Ahern wrote:

> On 2/13/26 1:48 AM, Nikolay Aleksandrov wrote:
> > If CONFIG_IRDMA isn't enabled but there are ice NICs in the system, the
> > driver will prevent full devlink dev param show dump because its rdma get
> > callbacks return ENODEV and stop the dump. For example:
> >  $ devlink dev param show
> >  pci/0000:82:00.0:
> >    name msix_vec_per_pf_max type generic
> >      values:
> >        cmode driverinit value 2
> >    name msix_vec_per_pf_min type generic
> >      values:
> >        cmode driverinit value 2
> >  kernel answers: No such device
> > 
> > Returning EOPNOTSUPP allows the dump to continue so we can see all devices'
> > devlink parameters.
> > 
> > Fixes: c24a65b6a27c ("iidc/ice/irdma: Update IDC to support multiple consumers")
> > Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
> > ---
> >  drivers/net/ethernet/intel/ice/devlink/devlink.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> 
> This patch was marked as awaiting upstream; I wanted to confirm it is in
> Intel's queue or was the expectation for netdev maintainer's to pick it up?

I see it's in Intel's queue.

https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git/log/?h=dev-queue

RE: [Intel-wired-lan] [PATCH net] drivers: net: ice: fix devlink parameters get without irdma

[Rinitha, SX]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Nikolay Aleksandrov via Intel-wired-lan
> Sent: 13 February 2026 14:19
> To: netdev@vger.kernel.org
> Cc: David Ahern <dsahern@kernel.org>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>; Andrew Lunn <andrew+netdev@lunn.ch>; davem@davemloft.net; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Loktionov, Aleksandr <aleksandr.loktionov@intel.com>; Greenwalt, Paul <paul.greenwalt@intel.com>; Daniel Zahka <daniel.zahka@gmail.com>; Michal Swiatkowski <michal.swiatkowski@linux.intel.com>; Ertman, David M <david.m.ertman@intel.com>; Mustafa Ismail <mustafa.ismail@intel.com>; Shiraz Saleem <shiraz.saleem@intel.com>; Nikolova, Tatyana E <tatyana.e.nikolova@intel.com>; intel-wired-lan@lists.osuosl.org; Nikolay Aleksandrov <nikolay@nvidia.com>
> Subject: [Intel-wired-lan] [PATCH net] drivers: net: ice: fix devlink parameters get without irdma
>
> If CONFIG_IRDMA isn't enabled but there are ice NICs in the system, the driver will prevent full devlink dev param show dump because its rdma get callbacks return ENODEV and stop the dump. For example:
> $ devlink dev param show
> pci/0000:82:00.0:
>   name msix_vec_per_pf_max type generic
>     values:
>       cmode driverinit value 2
>   name msix_vec_per_pf_min type generic
>     values:
>       cmode driverinit value 2
> kernel answers: No such device
>
> Returning EOPNOTSUPP allows the dump to continue so we can see all devices'
> devlink parameters.
>
> Fixes: c24a65b6a27c ("iidc/ice/irdma: Update IDC to support multiple consumers")
> Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
> ---
> drivers/net/ethernet/intel/ice/devlink/devlink.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel)