From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Nambiar, Amritha" <amritha.nambiar@intel.com>
Subject: Re: [net-next PATCH v5 3/7] net: sock: Change tx_queue_mapping in
 sock_common to unsigned short
Date: Sat, 30 Jun 2018 00:49:48 -0700
Message-ID: <56ee282a-8591-8133-d82a-b54fcde69606@intel.com>
References: <153013824922.4959.14633065530326138344.stgit@anamhost.jf.intel.com>
 <153013868881.4959.10801776136694650125.stgit@anamhost.jf.intel.com>
 <20180629.220511.870587764860032381.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, alexander.h.duyck@intel.com,
        willemdebruijn.kernel@gmail.com, sridhar.samudrala@intel.com,
        alexander.duyck@gmail.com, edumazet@google.com,
        hannes@stressinduktion.org, tom@herbertland.com, tom@quantonium.net
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mga03.intel.com ([134.134.136.65]:64711 "EHLO mga03.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752547AbeF3Htt (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 30 Jun 2018 03:49:49 -0400
In-Reply-To: <20180629.220511.870587764860032381.davem@davemloft.net>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 6/29/2018 6:05 AM, David Miller wrote:
> From: Amritha Nambiar <amritha.nambiar@intel.com>
> Date: Wed, 27 Jun 2018 15:31:28 -0700
> 
>> @@ -1681,17 +1681,25 @@ static inline int sk_receive_skb(struct sock *sk, struct sk_buff *skb,
>>  
>>  static inline void sk_tx_queue_set(struct sock *sk, int tx_queue)
>>  {
>> +	/* sk_tx_queue_mapping accept only upto a 16-bit value */
>> +	if (WARN_ON_ONCE((unsigned short)tx_queue > USHRT_MAX))
>> +		return;
>>  	sk->sk_tx_queue_mapping = tx_queue;
>>  }
>>  
>> +#define NO_QUEUE_MAPPING	USHRT_MAX
> 
> I think you need to check ">= USHRT_MAX" since USHRT_MAX is how you
> indicate no queue.
> 
Agree, I'll fix this.