From mboxrd@z Thu Jan 1 00:00:00 1970 From: "santosh.shilimkar@oracle.com" Subject: Re: [PATCH v2] rds: rds-stress show all zeros after few minutes Date: Sun, 3 Apr 2016 10:11:01 -0700 Message-ID: <57014EA5.4080002@oracle.com> References: <1459405762-29778-1-git-send-email-shamir.rabinovitch@oracle.com> <20160331.160246.2179579552166806534.davem@davemloft.net> <20160403122951.GA14675@shamir-linux.uk.oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: rds-devel@oss.oracle.com, netdev@vger.kernel.org To: Shamir Rabinovitch , David Miller Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:34323 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751582AbcDCRLO (ORCPT ); Sun, 3 Apr 2016 13:11:14 -0400 In-Reply-To: <20160403122951.GA14675@shamir-linux.uk.oracle.com> Sender: netdev-owner@vger.kernel.org List-ID: On 4/3/16 5:29 AM, Shamir Rabinovitch wrote: > On Thu, Mar 31, 2016 at 04:02:46PM -0400, David Miller wrote: >> From: shamir rabinovitch >> Date: Thu, 31 Mar 2016 02:29:22 -0400 >> >>> Issue can be seen on platforms that use 8K and above page size >>> while rds fragment size is 4K. On those platforms single page is >>> shared between 2 or more rds fragments. Each fragment has its own >>> offset and rds congestion map code need to take this offset to account. >>> Not taking this offset to account lead to reading the data fragment >>> as congestion map fragment and hang of the rds transmit due to far >>> congestion map corruption. >>> >>> Signed-off-by: shamir rabinovitch >>> >>> Reviewed-by: Wengang Wang >>> Reviewed-by: Ajaykumar Hotchandani >>> Acked-by: Santosh Shilimkar >>> Tested-by: Anand Bibhuti >> >> This doesn't apply cleanly to my current tree, please respin. > > Sorry for the trouble. > > Re-sent the patch based on net-next master. > Broke the patch according to comments from Santosh Shilimkar. > Thanks Shamir. Updated versions looks fine. You already have my ack included. Regards, Santosh