From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Hariprasad Shenai <hariprasad@chelsio.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, leedom@chelsio.com, nirranjan@chelsio.com
Subject: Re: [PATCH net-next] cxgb4/cxgb4vf: Deprecate module parameter dflt_msg_enable
Date: Mon, 4 Apr 2016 15:43:09 +0300 [thread overview]
Message-ID: <5702615D.6080905@cogentembedded.com> (raw)
In-Reply-To: <1459745604-8093-1-git-send-email-hariprasad@chelsio.com>
Hello.
On 4/4/2016 7:53 AM, Hariprasad Shenai wrote:
> Message level can be set through ethtool, so deprecate module parameter
> which is used to set the same.
>
> Signed-off-by: Hariprasad Shenai <hariprasad@chelsio.com>
> ---
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 3 ++-
> drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> index d1e3f0997d6b..acefa35b7250 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
> @@ -168,7 +168,8 @@ MODULE_PARM_DESC(force_init, "Forcibly become Master PF and initialize adapter,"
> static int dflt_msg_enable = DFLT_MSG_ENABLE;
>
> module_param(dflt_msg_enable, int, 0644);
> -MODULE_PARM_DESC(dflt_msg_enable, "Chelsio T4 default message enable bitmap");
> +MODULE_PARM_DESC(dflt_msg_enable, "Chelsio T4 default message enable bitmap,"
Need space after the last comma...
> + "deprecated parameter");
>
> /*
> * The driver uses the best interrupt scheme available on a platform in the
> diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
> index 1cc8a7a69457..730fec73d5a6 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
> @@ -74,7 +74,8 @@ static int dflt_msg_enable = DFLT_MSG_ENABLE;
>
> module_param(dflt_msg_enable, int, 0644);
> MODULE_PARM_DESC(dflt_msg_enable,
> - "default adapter ethtool message level bitmap");
> + "default adapter ethtool message level bitmap, "
... like here.
> + "deprecated parameter");
>
> /*
> * The driver uses the best interrupt scheme available on a platform in the
MBR, Sergei
prev parent reply other threads:[~2016-04-04 12:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 4:53 [PATCH net-next] cxgb4/cxgb4vf: Deprecate module parameter dflt_msg_enable Hariprasad Shenai
2016-04-04 12:43 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5702615D.6080905@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=hariprasad@chelsio.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).