From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [PATCH net 4/4] lib/test_bpf: Add additional BPF_ADD tests Date: Tue, 5 Apr 2016 09:28:34 -0700 Message-ID: <5703E7B2.6050706@fb.com> References: <5e3cf7c4a971e6d2ff7a2d50bbec2e6e26883b84.1459850410.git.naveen.n.rao@linux.vnet.ibm.com> <9b71e280481a9f84cd7dbb9e767fd08e6f4c0aef.1459850410.git.naveen.n.rao@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: Daniel Borkmann , "David S. Miller" , Ananth N Mavinakayanahalli , Michael Ellerman , Paul Mackerras To: "Naveen N. Rao" , , , Return-path: Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:51301 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753674AbcDEQ3L (ORCPT ); Tue, 5 Apr 2016 12:29:11 -0400 In-Reply-To: <9b71e280481a9f84cd7dbb9e767fd08e6f4c0aef.1459850410.git.naveen.n.rao@linux.vnet.ibm.com> Sender: netdev-owner@vger.kernel.org List-ID: On 4/5/16 3:02 AM, Naveen N. Rao wrote: > Some of these tests proved useful with the powerpc eBPF JIT port due to > sign-extended 16-bit immediate loads. Though some of these aspects get > covered in other tests, it is better to have explicit tests so as to > quickly tag the precise problem. > > Cc: Alexei Starovoitov > Cc: Daniel Borkmann > Cc: "David S. Miller" > Cc: Ananth N Mavinakayanahalli > Cc: Michael Ellerman > Cc: Paul Mackerras > Signed-off-by: Naveen N. Rao Makes sense. Looks like ppc jit will be using quite a bit of available ppc instructions. Nice. I'm assuming all these new tests passed with x64 jit? Acked-by: Alexei Starovoitov