From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: Debabrata Banerjee <dbanerje@akamai.com>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] macvlan: Support interface operstate properly
Date: Wed, 6 Apr 2016 23:27:08 +0200 [thread overview]
Message-ID: <57057F2C.9030304@cumulusnetworks.com> (raw)
In-Reply-To: <570579AA.6050400@cumulusnetworks.com>
On 04/06/2016 11:03 PM, Nikolay Aleksandrov wrote:
> On 04/06/2016 10:30 PM, Debabrata Banerjee wrote:
>> Set appropriate macvlan interface status based on lower device and our
>> status. Can be up, down, or lowerlayerdown.
>>
>> Signed-off-by: Debabrata Banerjee <dbanerje@akamai.com>
>>
>
> May I ask what is exactly that you're fixing here ? I recently had to make macvlan's
> operstates more accurate and I haven't experienced any wrong behaviour since commit
> de7d244d0a35 ("macvlan: make operstate and carrier more accurate").
> Also it's the linkwatch's job to take care for the proper operstate, we can use
> netif_stacked_transfer_operstate to help it, but I don't think directly setting
> operstate is a good idea.
Misread part of the change, got it now. My comment below still stands though,
> One more thing - you cannot use netdev_state_change() under the write_lock as it
> may sleep.
>
prev parent reply other threads:[~2016-04-06 21:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 20:30 [PATCH] macvlan: Support interface operstate properly Debabrata Banerjee
2016-04-06 21:03 ` Nikolay Aleksandrov
2016-04-06 21:26 ` Banerjee, Debabrata
2016-04-06 21:42 ` Nikolay Aleksandrov
2016-04-06 21:27 ` Nikolay Aleksandrov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57057F2C.9030304@cumulusnetworks.com \
--to=nikolay@cumulusnetworks.com \
--cc=dbanerje@akamai.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox