From: Lars Persson <lars.persson@axis.com>
To: Eric Dumazet <eric.dumazet@gmail.com>, Lars Persson <larper@axis.com>
Cc: <netdev@vger.kernel.org>, <jhs@mojatatu.com>,
<linux-kernel@vger.kernel.org>, <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH net v2] net: sched: do not requeue a NULL skb
Date: Mon, 11 Apr 2016 17:17:56 +0200 [thread overview]
Message-ID: <570BC024.1070504@axis.com> (raw)
In-Reply-To: <1460384551.6473.551.camel@edumazet-glaptop3.roam.corp.google.com>
On 04/11/2016 04:22 PM, Eric Dumazet wrote:
> On Mon, 2016-04-11 at 15:38 +0200, Lars Persson wrote:
>
>> I though it would be prudent because the queue can be non-empty even for
>> the case of skb=NULL. So should it be there in this patch, another patch
>> or not at all ?
>
> Then maybe change return code ?
>
> It seems strange that a validate_xmit_skb_list() failure stops the
> __qdisc_run() loop but schedules another round.
>
>
It was suggested by Cong Wang to return 0 in order to stop the loop. Do
you guys agree that the loop should be stopped for such failures ? Then
I will put the schedule call inside the if as you proposed earlier.
- Lars
next prev parent reply other threads:[~2016-04-11 15:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 6:24 [PATCH net v2] net: sched: do not requeue a NULL skb Lars Persson
2016-04-11 13:23 ` Eric Dumazet
2016-04-11 13:38 ` Lars Persson
2016-04-11 14:22 ` Eric Dumazet
2016-04-11 15:17 ` Lars Persson [this message]
2016-04-11 15:52 ` Eric Dumazet
2016-04-11 18:02 ` Cong Wang
2016-04-11 18:26 ` Eric Dumazet
2016-04-11 18:30 ` Eric Dumazet
2016-04-11 23:19 ` Cong Wang
2016-04-11 23:48 ` Eric Dumazet
2016-04-11 17:53 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570BC024.1070504@axis.com \
--to=lars.persson@axis.com \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=larper@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).