From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] sh_eth: re-enable-E-MAC interrupts in sh_eth_set_ringparam()
Date: Mon, 11 Apr 2016 20:10:50 +0300 [thread overview]
Message-ID: <570BDA9A.4030107@cogentembedded.com> (raw)
In-Reply-To: <20160409.212725.649496142802966013.davem@davemloft.net>
Hello.
On 04/10/2016 04:27 AM, David Miller wrote:
>> The E-MAC interrupts are left disabled when the ring parameters are changed
>> via 'ethtool'. In order to fix this, it's enough to call sh_eth_dev_init()
>> with 'true' instead of 'false' for the second argument (which conveniently
>> allows us to remove the following code re-enabling E-DMAC interrupts and
>> reception).
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> Applied, thanks.
Thanks!
Unfortunately, this patch isn't fit for the stable kernels because there's
a prerequisite cleanup (most recent patch merged to this driver). I clearly
hadn't thought this out well -- should have enabled the E-MAC interrupts
outside sh_eth_dev_init() and then removed the duplicate code like I did here.
MBR, Sergei
prev parent reply other threads:[~2016-04-11 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-09 23:28 [PATCH] sh_eth: re-enable-E-MAC interrupts in sh_eth_set_ringparam() Sergei Shtylyov
2016-04-10 1:27 ` David Miller
2016-04-11 17:10 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570BDA9A.4030107@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).