netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Subject: Re: [PATCH v2 net-next 0/7] DSA refactoring: set 1
Date: Wed, 13 Apr 2016 12:22:51 -0700	[thread overview]
Message-ID: <570E9C8B.2080100@gmail.com> (raw)
In-Reply-To: <1460508045-20254-1-git-send-email-andrew@lunn.ch>

On 12/04/16 17:40, Andrew Lunn wrote:
> There has been a long running effort to refractor DSA probing to make
> the switches true linux devices. Here are a small collection of
> patches moving in this direction. Most have been seen before.
> 
> We take a little step forward by passing the dsa device point to the
> driver, thus allowing it to perform resource allocations using the
> normal mechanisms. This device structure will later be replaced by the
> devices own device structure.
> 
> Future patches will add a true driver probe function, so we rename the
> current probe function, cleaning up the namespace.
> 
> phys_port_mask continually confuses me, thinking it is about PHYs. But
> it is actually about ports enabled to the outside world. So rename it to
> enabled_port_mask.
> 
> Lots more patches yet to follow, this is just doing some ground work.

Tested-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks Andrew!

> 
> v2:
>   enabled_port_mask instread of user_port_masks
>   Added Tested-by's and Reviewed-by.
> 
> Andrew Lunn (7):
>   net: dsa: Pass the dsa device to the switch drivers
>   net: dsa: Have the switch driver allocate there own private memory
>   net: dsa: Remove allocation of driver private memory
>   net: dsa: Keep the mii bus and address in the private structure
>   net: dsa: Rename DSA probe function.
>   dsa: Rename phys_port_mask to user_port_mask
>   dsa: mv88e6xxx: Use bus in mv88e6xxx_lookup_name()
> 
>  drivers/net/dsa/bcm_sf2.c   | 24 +++++++++++++-------
>  drivers/net/dsa/mv88e6060.c | 47 +++++++++++++++++++++++---------------
>  drivers/net/dsa/mv88e6060.h | 11 +++++++++
>  drivers/net/dsa/mv88e6123.c | 14 +++++++-----
>  drivers/net/dsa/mv88e6131.c | 14 +++++++-----
>  drivers/net/dsa/mv88e6171.c | 14 +++++++-----
>  drivers/net/dsa/mv88e6352.c | 14 +++++++-----
>  drivers/net/dsa/mv88e6xxx.c | 55 +++++++++++++++++++++++++++++++--------------
>  drivers/net/dsa/mv88e6xxx.h | 17 +++++++++++---
>  include/net/dsa.h           | 16 ++++++++-----
>  net/dsa/dsa.c               | 19 +++++++++-------
>  11 files changed, 166 insertions(+), 79 deletions(-)
> 


-- 
Florian

  parent reply	other threads:[~2016-04-13 19:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-13  0:40 [PATCH v2 net-next 0/7] DSA refactoring: set 1 Andrew Lunn
2016-04-13  0:40 ` [PATCH v2 net-next 1/7] net: dsa: Pass the dsa device to the switch drivers Andrew Lunn
2016-04-13  0:40 ` [PATCH v2 net-next 2/7] net: dsa: Have the switch driver allocate there own private memory Andrew Lunn
2016-04-13  0:40 ` [PATCH v2 net-next 3/7] net: dsa: Remove allocation of driver " Andrew Lunn
2016-04-13  0:40 ` [PATCH v2 net-next 4/7] net: dsa: Keep the mii bus and address in the private structure Andrew Lunn
2016-04-13  0:40 ` [PATCH v2 net-next 5/7] net: dsa: Rename DSA probe function Andrew Lunn
2016-04-13 19:29   ` Florian Fainelli
2016-04-13  0:40 ` [PATCH v2 net-next 6/7] dsa: Rename phys_port_mask to enabled_port_mask Andrew Lunn
2016-04-13 19:29   ` Florian Fainelli
2016-04-13  0:40 ` [PATCH v2 net-next 7/7] dsa: mv88e6xxx: Use bus in mv88e6xxx_lookup_name() Andrew Lunn
2016-04-13 19:22 ` Florian Fainelli [this message]
2016-04-13 22:15 ` [PATCH v2 net-next 0/7] DSA refactoring: set 1 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570E9C8B.2080100@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).