* [PATCH net-next] ptp: ocp: fix error code in probe()
@ 2023-09-27 12:55 Dan Carpenter
2023-09-27 13:54 ` Vadim Fedorenko
2023-10-04 20:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2023-09-27 12:55 UTC (permalink / raw)
To: Vadim Fedorenko
Cc: Richard Cochran, Jonathan Lemon, Vadim Fedorenko, David S. Miller,
Jiri Pirko, Arkadiusz Kubalewski, netdev, kernel-janitors
There is a copy and paste error so this uses a valid pointer instead of
an error pointer.
Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/ptp/ptp_ocp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
index 88d60a9b5731..d39afe091a7b 100644
--- a/drivers/ptp/ptp_ocp.c
+++ b/drivers/ptp/ptp_ocp.c
@@ -4453,7 +4453,7 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
for (i = 0; i < OCP_SMA_NUM; i++) {
bp->sma[i].dpll_pin = dpll_pin_get(clkid, i, THIS_MODULE, &bp->sma[i].dpll_prop);
if (IS_ERR(bp->sma[i].dpll_pin)) {
- err = PTR_ERR(bp->dpll);
+ err = PTR_ERR(bp->sma[i].dpll_pin);
goto out_dpll;
}
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] ptp: ocp: fix error code in probe()
2023-09-27 12:55 [PATCH net-next] ptp: ocp: fix error code in probe() Dan Carpenter
@ 2023-09-27 13:54 ` Vadim Fedorenko
2023-10-04 20:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Vadim Fedorenko @ 2023-09-27 13:54 UTC (permalink / raw)
To: Dan Carpenter
Cc: Richard Cochran, Jonathan Lemon, Vadim Fedorenko, David S. Miller,
Jiri Pirko, Arkadiusz Kubalewski, netdev, kernel-janitors
On 27/09/2023 13:55, Dan Carpenter wrote:
> There is a copy and paste error so this uses a valid pointer instead of
> an error pointer.
>
> Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/ptp/ptp_ocp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index 88d60a9b5731..d39afe091a7b 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -4453,7 +4453,7 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> for (i = 0; i < OCP_SMA_NUM; i++) {
> bp->sma[i].dpll_pin = dpll_pin_get(clkid, i, THIS_MODULE, &bp->sma[i].dpll_prop);
> if (IS_ERR(bp->sma[i].dpll_pin)) {
> - err = PTR_ERR(bp->dpll);
> + err = PTR_ERR(bp->sma[i].dpll_pin);
> goto out_dpll;
> }
>
Thanks!
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] ptp: ocp: fix error code in probe()
2023-09-27 12:55 [PATCH net-next] ptp: ocp: fix error code in probe() Dan Carpenter
2023-09-27 13:54 ` Vadim Fedorenko
@ 2023-10-04 20:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-10-04 20:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: vadim.fedorenko, richardcochran, jonathan.lemon, vadfed, davem,
jiri, arkadiusz.kubalewski, netdev, kernel-janitors
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 27 Sep 2023 15:55:10 +0300 you wrote:
> There is a copy and paste error so this uses a valid pointer instead of
> an error pointer.
>
> Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/ptp/ptp_ocp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net-next] ptp: ocp: fix error code in probe()
https://git.kernel.org/netdev/net-next/c/24a0fbf48cbe
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-04 20:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-27 12:55 [PATCH net-next] ptp: ocp: fix error code in probe() Dan Carpenter
2023-09-27 13:54 ` Vadim Fedorenko
2023-10-04 20:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).