From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77D64C433E0 for ; Thu, 18 Jun 2020 05:32:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D02E217A0 for ; Thu, 18 Jun 2020 05:32:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726979AbgFRFcl (ORCPT ); Thu, 18 Jun 2020 01:32:41 -0400 Received: from smtprelay0048.hostedemail.com ([216.40.44.48]:49946 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725837AbgFRFcl (ORCPT ); Thu, 18 Jun 2020 01:32:41 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 2E0971E14; Thu, 18 Jun 2020 05:32:40 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: offer98_5e027c126e0d X-Filterd-Recvd-Size: 3259 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf10.hostedemail.com (Postfix) with ESMTPA; Thu, 18 Jun 2020 05:32:34 +0000 (UTC) Message-ID: <57110139759cc77f21a150a3faed0d2584dfbe21.camel@perches.com> Subject: Re: [net-next 02/15] iecm: Add framework set of header files From: Joe Perches To: Jeff Kirsher , davem@davemloft.net Cc: Alice Michael , netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, Alan Brady , Phani Burra , Joshua Hay , Madhu Chittim , Pavan Kumar Linga , Donald Skidmore , Jesse Brandeburg , Sridhar Samudrala Date: Wed, 17 Jun 2020 22:32:33 -0700 In-Reply-To: <20200618051344.516587-3-jeffrey.t.kirsher@intel.com> References: <20200618051344.516587-1-jeffrey.t.kirsher@intel.com> <20200618051344.516587-3-jeffrey.t.kirsher@intel.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.2-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 2020-06-17 at 22:13 -0700, Jeff Kirsher wrote: > From: Alice Michael [] > diff --git a/include/linux/net/intel/iecm_controlq_api.h b/include/linux/net/intel/iecm_controlq_api.h [] > +enum iecm_ctlq_err { > + IECM_CTLQ_RC_OK = 0, /* Success */ Why is it necessary to effectively duplicate the generic error codes with different error numbers? > + IECM_CTLQ_RC_EPERM = 1, /* Operation not permitted */ > + IECM_CTLQ_RC_ENOENT = 2, /* No such element */ > + IECM_CTLQ_RC_ESRCH = 3, /* Bad opcode */ > + IECM_CTLQ_RC_EINTR = 4, /* Operation interrupted */ > + IECM_CTLQ_RC_EIO = 5, /* I/O error */ > + IECM_CTLQ_RC_ENXIO = 6, /* No such resource */ > + IECM_CTLQ_RC_E2BIG = 7, /* Arg too long */ > + IECM_CTLQ_RC_EAGAIN = 8, /* Try again */ > + IECM_CTLQ_RC_ENOMEM = 9, /* Out of memory */ > + IECM_CTLQ_RC_EACCES = 10, /* Permission denied */ > + IECM_CTLQ_RC_EFAULT = 11, /* Bad address */ > + IECM_CTLQ_RC_EBUSY = 12, /* Device or resource busy */ > + IECM_CTLQ_RC_EEXIST = 13, /* object already exists */ > + IECM_CTLQ_RC_EINVAL = 14, /* Invalid argument */ > + IECM_CTLQ_RC_ENOTTY = 15, /* Not a typewriter */ > + IECM_CTLQ_RC_ENOSPC = 16, /* No space left or allocation failure */ > + IECM_CTLQ_RC_ENOSYS = 17, /* Function not implemented */ > + IECM_CTLQ_RC_ERANGE = 18, /* Parameter out of range */ > + IECM_CTLQ_RC_EFLUSHED = 19, /* Cmd flushed due to prev cmd error */ > + IECM_CTLQ_RC_BAD_ADDR = 20, /* Descriptor contains a bad pointer */ > + IECM_CTLQ_RC_EMODE = 21, /* Op not allowed in current dev mode */ > + IECM_CTLQ_RC_EFBIG = 22, /* File too big */ > + IECM_CTLQ_RC_ENOSEC = 24, /* Missing security manifest */ > + IECM_CTLQ_RC_EBADSIG = 25, /* Bad RSA signature */ > + IECM_CTLQ_RC_ESVN = 26, /* SVN number prohibits this package */ > + IECM_CTLQ_RC_EBADMAN = 27, /* Manifest hash mismatch */ > + IECM_CTLQ_RC_EBADBUF = 28, /* Buffer hash mismatches manifest */ > +};