From mboxrd@z Thu Jan 1 00:00:00 1970 From: Denys Vlasenko Subject: Re: [PATCH 1/3] e1000e: e1000e_cyclecounter_read(): incvalue is 32 bits, not 64 Date: Wed, 20 Apr 2016 17:43:05 +0200 Message-ID: <5717A389.5070902@redhat.com> References: <1461069286-31946-1-git-send-email-dvlasenk@redhat.com> <1461099434.2923.6.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Jeff Kirsher Return-path: Received: from mx1.redhat.com ([209.132.183.28]:34027 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751973AbcDTPnH (ORCPT ); Wed, 20 Apr 2016 11:43:07 -0400 In-Reply-To: <1461099434.2923.6.camel@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: On 04/19/2016 10:57 PM, Jeff Kirsher wrote: > On Tue, 2016-04-19 at 14:34 +0200, Denys Vlasenko wrote: >> "incvalue" variable holds a result of "er32(TIMINCA) & >> E1000_TIMINCA_INCVALUE_MASK" >> and used in "do_div(temp, incvalue)" as a divisor. >> >> Thus, "u64 incvalue" declaration is probably a mistake. >> Even though it seems to be a harmless one, let's fix it. >> >> Signed-off-by: Denys Vlasenko >> CC: Jeff Kirsher >> CC: Jesse Brandeburg >> CC: Shannon Nelson >> CC: Carolyn Wyborny >> CC: Don Skidmore >> CC: Bruce Allan >> CC: John Ronciak >> CC: Mitch Williams >> CC: David S. Miller >> CC: LKML >> CC: netdev@vger.kernel.org >> --- >> drivers/net/ethernet/intel/e1000e/netdev.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > First of all, trimmed down the recipient list since almost all of the > reviewers you added have nothing to do with e1000e. I took the list here, MAINTAINERS: INTEL ETHERNET DRIVERS M: Jeff Kirsher R: Jesse Brandeburg R: Shannon Nelson R: Carolyn Wyborny R: Don Skidmore R: Bruce Allan R: John Ronciak R: Mitch Williams No more specific information who's e1000e reviewer. Sorry.