From mboxrd@z Thu Jan 1 00:00:00 1970 From: Balbir Singh Subject: Re: [PATCH net-next 9/9] taskstats: use the libnl API to align nlattr on 64-bit Date: Wed, 27 Apr 2016 22:29:22 +1000 Message-ID: <5720B0A2.1030405@gmail.com> References: <1461339084-3849-1-git-send-email-nicolas.dichtel@6wind.com> <1461339084-3849-10-git-send-email-nicolas.dichtel@6wind.com> <57201287.80002@gmail.com> <57206A47.2010906@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, linux-wpan@vger.kernel.org, aar@pengutronix.de, pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu, pshelar@nicira.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, netfilter-devel@vger.kernel.org, dev@openvswitch.org, steffen.klassert@secunet.com, herbert@gondor.apana.org.au To: nicolas.dichtel@6wind.com, netdev@vger.kernel.org Return-path: In-Reply-To: <57206A47.2010906@6wind.com> Sender: netfilter-devel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 27/04/16 17:29, Nicolas Dichtel wrote: > Le 27/04/2016 03:14, Balbir Singh a =E9crit : >> >> >> On 23/04/16 01:31, Nicolas Dichtel wrote: >>> Goal of this patch is to use the new libnl API to align netlink att= ribute >>> when needed. >>> The layout of the netlink message will be a bit different after the= patch, >>> because the padattr (TASKSTATS_TYPE_STATS) will be inside the neste= d >>> attribute instead of before it. >>> >>> Signed-off-by: Nicolas Dichtel >> >> The layout will change/break user space -- I've not tested the patch= though.. > Sigh. >=20 > I quote David: > "All userspace components using netlink should always ignore attribut= es > they do not recognize in dumps. >=20 > This is one of the most basic principles of netlink" >=20 > Do you have some pointers so I can made some tests? >=20 Please try https://www.kernel.org/doc/Documentation/accounting/getdelays.c iotop uses it as well. My concern is ABI breakage of user space. Balbir Singh -- To unsubscribe from this list: send the line "unsubscribe netfilter-dev= el" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html