From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, donald.hunter@gmail.com,
kuniyu@google.com
Subject: Re: [PATCH net-next 1/3] netlink: specs: fou: add af to the shared attribute list
Date: Mon, 7 Sep 2026 12:04:31 +0200 [thread overview]
Message-ID: <572c628f-b297-4b60-ae17-3c39346331d8@6wind.com> (raw)
In-Reply-To: <20260904191412.3872344-2-kuba@kernel.org>
Le 04/09/2026 à 21:14, Jakub Kicinski a écrit :
> parse_nl_config() is the only place the address family is chosen: it
> defaults cfg->udp_config.family to AF_INET and only switches to
> AF_INET6 when FOU_ATTR_AF is present. The &all_attrs anchor - the add
> request, and the get do and dump reply - does not list af, so a ynl
> generated client has no fou_add_req_set_af() and can never create an
> IPv6 FOU port; the local-v6 / peer-v6 attributes it does list are read
> by nothing. On the reply side fou_fill_info() puts FOU_ATTR_AF
> unconditionally, and struct fou_get_rsp has no member for it.
>
> kernel-policy is global, so fou_nl_ops[] carries no per-op attribute
> list and af is already in fou_nl_policy through &select_attrs - only
> the user space codegen and the rendered docs change, ynl-regen.sh
> produces no diff.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
next prev parent reply other threads:[~2026-09-07 10:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 19:14 [PATCH net-next 0/3] netlink: specs: fou: spec tweaks Jakub Kicinski
2026-09-04 19:14 ` [PATCH net-next 1/3] netlink: specs: fou: add af to the shared attribute list Jakub Kicinski
2026-09-07 10:04 ` Nicolas Dichtel [this message]
2026-09-07 19:14 ` netdev-bot+sashiko
2026-09-04 19:14 ` [PATCH net-next 2/3] netlink: specs: fou: local-v4 and peer-v4 are big endian Jakub Kicinski
2026-09-07 10:05 ` Nicolas Dichtel
2026-09-07 19:14 ` netdev-bot+sashiko
2026-09-08 10:56 ` Paolo Abeni
2026-09-04 19:14 ` [PATCH net-next 3/3] netlink: specs: fou: link the type attribute to the encap-type enum Jakub Kicinski
2026-09-07 10:05 ` Nicolas Dichtel
2026-09-08 11:00 ` [PATCH net-next 0/3] netlink: specs: fou: spec tweaks patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572c628f-b297-4b60-ae17-3c39346331d8@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox