From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] net: Reset skb to network header in neigh_hh_output Date: Fri, 7 Oct 2016 19:27:34 +0300 Message-ID: <572cddd1-6a03-4c83-1e0e-55be37273396@cogentembedded.com> References: <1579f7f0f4f.114457ec828613.4349884782265574217@abahmed.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev , linux-kernel To: Abdelrhman Ahmed , davem Return-path: Received: from mail-lf0-f53.google.com ([209.85.215.53]:36373 "EHLO mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939026AbcJGQ1i (ORCPT ); Fri, 7 Oct 2016 12:27:38 -0400 Received: by mail-lf0-f53.google.com with SMTP id b75so45161362lfg.3 for ; Fri, 07 Oct 2016 09:27:37 -0700 (PDT) In-Reply-To: <1579f7f0f4f.114457ec828613.4349884782265574217@abahmed.com> Sender: netdev-owner@vger.kernel.org List-ID: Hello. On 10/07/2016 05:14 PM, Abdelrhman Ahmed wrote: > When hardware header is added without using cached one, neigh_resolve_output > and neigh_connected_output reset skb to network header before adding it. > When cached one is used, neigh_hh_output does not reset the skb to network > header. > > The fix is to reset skb to network header before adding cached hardware header > to keep the behavior consistent in all cases. > > Signed-off-by: Abdelrhman Ahmed > --- > include/net/neighbour.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/net/neighbour.h b/include/net/neighbour.h > index 8b68384..4d89fc2 100644 > --- a/include/net/neighbour.h > +++ b/include/net/neighbour.h > @@ -424,7 +424,7 @@ static inline struct neighbour * neigh_clone(struct neighbour *neigh) > static inline int neigh_event_send(struct neighbour *neigh, struct sk_buff *skb) > { > unsigned long now = jiffies; > - > + Unraleted white-space change. > if (neigh->used != now) > neigh->used = now; > if (!(neigh->nud_state&(NUD_CONNECTED|NUD_DELAY|NUD_PROBE))) [...] MBR, Sergei