From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, tgraf@suug.ch,
nicolas.dichtel@6wind.com, nikolay@cumulusnetworks.com
Subject: Re: [PATCH iproute2 net-next] ifstat: move to new RTM_GETSTATS api
Date: Wed, 11 May 2016 07:24:23 -0400 [thread overview]
Message-ID: <57331667.5090208@mojatatu.com> (raw)
In-Reply-To: <57320B6A.3090301@cumulusnetworks.com>
On 16-05-10 12:25 PM, Roopa Prabhu wrote:
> On 5/9/16, 5:38 AM, Jamal Hadi Salim wrote:
>> Is it not possible to convert to 64b - and IFLA_STAT
>> becomes available just store it still in 64b?
>> i.e 32b will fit in 64b space.
>
> The only problem is again if the last saved history file had 32 bit
> and 32bit counters may roll over earlier.
>
I am not sure there is a good case of someone upgrading from 32b to 64b.
> One more thing i am looking at right now which might work is using
> the existing history file and use the info_source (aka header) in ifstat history file to indicate
> 32bit or 64bit stats. For 32 bit it is currently "#kernel".
> For 64 bit i plan to use "#kernel64".
>
Good idea.
> If we are starting a new history file, i will always use 64bit and when using an existing history file,
> it will use 32bit.
>
> And 64bit stats will be queried with RTM_GETSTATS if available or will use IFLA_STATS64 when
> RTM_NEWLINK Is used.
>
> will see if i can get this working for all cases,
Yes, this would work.
Release it and see if someone is going to complain.
cheers,
jamal
prev parent reply other threads:[~2016-05-11 11:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-30 6:41 [PATCH iproute2 net-next] ifstat: move to new RTM_GETSTATS api Roopa Prabhu
2016-04-30 10:21 ` Jamal Hadi Salim
2016-04-30 15:15 ` Roopa Prabhu
2016-05-09 4:49 ` Roopa Prabhu
2016-05-09 12:38 ` Jamal Hadi Salim
2016-05-10 16:25 ` Roopa Prabhu
2016-05-11 11:24 ` Jamal Hadi Salim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57331667.5090208@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).