From: "Yankejian (Hackim Yim)" <yankejian@huawei.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Yisen Zhuang <Yisen.Zhuang@huawei.com>, <davem@davemloft.net>,
<rjw@rjwysocki.net>, <lenb@kernel.org>
Cc: <arnd@arndb.de>, <andrew@lunn.ch>, <geliangtang@163.com>,
<ivecera@redhat.com>, <fengguang.wu@intel.com>,
<charles.chenxin@huawei.com>, <haifeng.wei@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>
Subject: Re: [patch net-next 06/11] ACPI: bus: move acpi_match_device_ids() to linux/acpi.h
Date: Mon, 16 May 2016 09:57:33 +0800 [thread overview]
Message-ID: <5739290D.9020701@huawei.com> (raw)
In-Reply-To: <1463145312.17131.347.camel@linux.intel.com>
On 2016/5/13 21:15, Andy Shevchenko wrote:
> On Fri, 2016-05-13 at 16:19 +0800, Yisen Zhuang wrote:
>> From: Hanjun Guo <hanjun.guo@linaro.org>
>>
>> acpi_match_device_ids() will be used for drivers to match
>> different hardware versions, it will be compiled in non-ACPI
>> case, but acpi_match_device_ids() in acpi_bus.h and it can
>> only be used in ACPI case, so move it to linux/acpi.h and
>> introduce a stub function for it.
> I somehow doubt this is right move.
>
> Like I said in the previous comment the architectural split might make
> this a bit better.
>
> You might use
>
> #ifdef IS_ENABLED(CONFIG_ACPI)
> #else
> #endif
>
> only once to some big part of code. If kernel is build without ACPI
> support you even will not have this in your driver at all.
Hi Andy,
Thanks for your suggestions. It will add stub function instead in next submit.
> --
> Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Intel Finland Oy
>
>
> .
>
next prev parent reply other threads:[~2016-05-16 1:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 8:19 [patch net-next 00/11] net: hns: add support of ACPI Yisen Zhuang
2016-05-13 8:19 ` [patch net-next 01/11] net: hisilicon: add support of acpi for hns-mdio Yisen Zhuang
2016-05-13 12:59 ` Andy Shevchenko
2016-05-16 7:10 ` Yankejian (Hackim Yim)
2016-05-13 8:19 ` [patch net-next 02/11] net: hns: use device_* APIs instead of of_* APIs Yisen Zhuang
2016-05-13 8:19 ` [patch net-next 03/11] net: hns: use platform_get_irq instead of irq_of_parse_and_map Yisen Zhuang
2016-05-13 8:19 ` [patch net-next 04/11] net: hns: enet specify a reference to dsaf by fwnode_handle Yisen Zhuang
2016-05-13 13:01 ` Andy Shevchenko
2016-05-13 8:19 ` [patch net-next 05/11] net: hns: add uniform interface for phy connection Yisen Zhuang
2016-05-13 13:07 ` Andy Shevchenko
2016-05-16 0:40 ` Yankejian (Hackim Yim)
2016-05-13 8:19 ` [patch net-next 06/11] ACPI: bus: move acpi_match_device_ids() to linux/acpi.h Yisen Zhuang
2016-05-13 13:15 ` Andy Shevchenko
2016-05-16 1:57 ` Yankejian (Hackim Yim) [this message]
2016-05-13 8:19 ` [patch net-next 07/11] net: hns: dsaf adds support of acpi Yisen Zhuang
2016-05-13 13:12 ` Andy Shevchenko
2016-05-16 2:06 ` Yankejian (Hackim Yim)
2016-05-13 8:19 ` [patch net-next 08/11] net: hns: register phy device in each mac initial sequence Yisen Zhuang
2016-05-13 8:29 ` kbuild test robot
2016-05-13 8:19 ` [patch net-next 09/11] ACPI: bus: add stub acpi_evaluate_dsm() to linux/acpi.h Yisen Zhuang
2016-05-13 8:19 ` [patch net-next 10/11] net: hns: implement the reset sequence by asl Yisen Zhuang
2016-05-13 8:19 ` [patch net-next 11/11] net: hns: enet adds support of acpi Yisen Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5739290D.9020701@huawei.com \
--to=yankejian@huawei.com \
--cc=Yisen.Zhuang@huawei.com \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=charles.chenxin@huawei.com \
--cc=davem@davemloft.net \
--cc=fengguang.wu@intel.com \
--cc=geliangtang@163.com \
--cc=haifeng.wei@huawei.com \
--cc=ivecera@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).