From: Dan Murphy <dmurphy@ti.com>
To: Alexander Graf <agraf@suse.de>, David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<michal.simek@xilinx.com>, <andrew@lunn.ch>
Subject: Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional
Date: Tue, 17 May 2016 15:40:01 -0500 [thread overview]
Message-ID: <573B81A1.7000701@ti.com> (raw)
In-Reply-To: <2C61E1D8-A99E-4B5D-A4CE-F2394A784889@suse.de>
On 05/17/2016 03:37 PM, Alexander Graf wrote:
> Hi David,
>
>> Am 17.05.2016 um 20:48 schrieb David Miller <davem@davemloft.net>:
>>
>> From: Dan Murphy <dmurphy@ti.com>
>> Date: Tue, 17 May 2016 13:34:34 -0500
>>
>>> David
>>>
>>>> On 05/17/2016 01:22 PM, David Miller wrote:
>>>> From: Alexander Graf <agraf@suse.de>
>>>> Date: Mon, 16 May 2016 20:52:43 +0200
>>>>
>>>>> If you compile without OF_MDIO support in an RGMII configuration, we fail
>>>>> to configure the dp83867 phy today by writing garbage into its configuration
>>>>> registers.
>>>>>
>>>>> On the other hand if you do compile with OF_MDIO and the phy gets loaded via
>>>>> device tree, you have to have the properties set in the device tree, otherwise
>>>>> we fail to load the driver and don't even attach the generic phy driver to
>>>>> the interface anymore.
>>>>>
>>>>> To make things slightly more consistent, make the rgmii configuration properties
>>>>> optional and allow a user to omit them in their device tree.
>>>>>
>>>>> Signed-off-by: Alexander Graf <agraf@suse.de>
>>>> Applied.
>>> This patch should not have been applied.
>>>
>>> I did not believe the implementation was proper for that driver.
>>>
>>> It seems my objection to the code was not seen. Nor was Andrew's point about the DT bindings document
>>>
>>> https://patchwork.kernel.org/patch/9105371/
>> The discussions around the recent phy patches have been a labrynth that I've
>> found hard to follow, sorry.
>>
>> I'll revert these two, sigh....
> The first patch is an obvious and correct fix. Discussions were only about the second one (which I'm happy to drop given the rat hole this turned out to be).
So are you going to abandon the second patch all together?
If you do, let me know I can submit a patch.
Dan
>
> Alex
>
>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2016-05-17 20:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 18:52 [PATCH v2 1/2] phy dp83867: Fix compilation with CONFIG_OF_MDIO=m Alexander Graf
2016-05-16 18:52 ` [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional Alexander Graf
2016-05-16 19:04 ` Florian Fainelli
2016-05-16 20:15 ` Andrew Lunn
2016-05-16 20:27 ` Dan Murphy
2016-05-17 18:22 ` David Miller
2016-05-17 18:34 ` Dan Murphy
2016-05-17 18:48 ` David Miller
2016-05-17 20:37 ` Alexander Graf
2016-05-17 20:40 ` Dan Murphy [this message]
2016-05-17 20:45 ` Alexander Graf
2016-05-17 18:22 ` [PATCH v2 1/2] phy dp83867: Fix compilation with CONFIG_OF_MDIO=m David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573B81A1.7000701@ti.com \
--to=dmurphy@ti.com \
--cc=agraf@suse.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).