* [PATCH 1/1] net: thunderx: avoid null pointer dereference
@ 2016-05-17 19:40 Heinrich Schuchardt
2016-05-17 20:21 ` David Daney
2016-05-19 18:25 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2016-05-17 19:40 UTC (permalink / raw)
To: Sunil Goutham, Robert Richter
Cc: netdev, linux-kernel, linux-arm-kernel, Heinrich Schuchardt
In function bgx_lmac_handler only use a member of
lmac after checking it is not null.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
index d20539a..3ed2198 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
+++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
@@ -274,12 +274,14 @@ static void bgx_sgmii_change_link_state(struct lmac *lmac)
static void bgx_lmac_handler(struct net_device *netdev)
{
struct lmac *lmac = container_of(netdev, struct lmac, netdev);
- struct phy_device *phydev = lmac->phydev;
+ struct phy_device *phydev;
int link_changed = 0;
if (!lmac)
return;
+ phydev = lmac->phydev;
+
if (!phydev->link && lmac->last_link)
link_changed = -1;
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] net: thunderx: avoid null pointer dereference
2016-05-17 19:40 [PATCH 1/1] net: thunderx: avoid null pointer dereference Heinrich Schuchardt
@ 2016-05-17 20:21 ` David Daney
2016-05-17 21:37 ` Heinrich Schuchardt
2016-05-19 18:25 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: David Daney @ 2016-05-17 20:21 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: Sunil Goutham, Robert Richter, netdev, linux-kernel,
linux-arm-kernel
On 05/17/2016 12:40 PM, Heinrich Schuchardt wrote:
> In function bgx_lmac_handler only use a member of
> lmac after checking it is not null.
>
Were you seeing and actual OOPs, or is this only a theoretical problem
flagged by some sort of static code checker?
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
In any event, it seems sane to make this change, so:
Acked-by: David Daney <david.daney@cavium.com>
> ---
> drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> index d20539a..3ed2198 100644
> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> @@ -274,12 +274,14 @@ static void bgx_sgmii_change_link_state(struct lmac *lmac)
> static void bgx_lmac_handler(struct net_device *netdev)
> {
> struct lmac *lmac = container_of(netdev, struct lmac, netdev);
> - struct phy_device *phydev = lmac->phydev;
> + struct phy_device *phydev;
> int link_changed = 0;
>
> if (!lmac)
> return;
>
> + phydev = lmac->phydev;
> +
> if (!phydev->link && lmac->last_link)
> link_changed = -1;
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] net: thunderx: avoid null pointer dereference
2016-05-17 20:21 ` David Daney
@ 2016-05-17 21:37 ` Heinrich Schuchardt
0 siblings, 0 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2016-05-17 21:37 UTC (permalink / raw)
To: David Daney
Cc: Sunil Goutham, Robert Richter, netdev, linux-kernel,
linux-arm-kernel
On 05/17/2016 10:21 PM, David Daney wrote:
> On 05/17/2016 12:40 PM, Heinrich Schuchardt wrote:
>> In function bgx_lmac_handler only use a member of
>> lmac after checking it is not null.
>>
>
> Were you seeing and actual OOPs, or is this only a theoretical problem
> flagged by some sort of static code checker?
Cppcheck identified the code inconsistency.
If the struct netdev * parameter cannot be NULL, you could eliminate the
check.
Other drivers do no have check against a NULL parameter in the
adjust_link handler function (e.g. bgmac_adjust_link,
pxa168_eth_adjust_link).
Best regards
Heinrich
>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
> In any event, it seems sane to make this change, so:
>
> Acked-by: David Daney <david.daney@cavium.com>
>
>
>> ---
>> drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
>> b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
>> index d20539a..3ed2198 100644
>> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
>> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
>> @@ -274,12 +274,14 @@ static void bgx_sgmii_change_link_state(struct
>> lmac *lmac)
>> static void bgx_lmac_handler(struct net_device *netdev)
>> {
>> struct lmac *lmac = container_of(netdev, struct lmac, netdev);
>> - struct phy_device *phydev = lmac->phydev;
>> + struct phy_device *phydev;
>> int link_changed = 0;
>>
>> if (!lmac)
>> return;
>>
>> + phydev = lmac->phydev;
>> +
>> if (!phydev->link && lmac->last_link)
>> link_changed = -1;
>>
>>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] net: thunderx: avoid null pointer dereference
2016-05-17 19:40 [PATCH 1/1] net: thunderx: avoid null pointer dereference Heinrich Schuchardt
2016-05-17 20:21 ` David Daney
@ 2016-05-19 18:25 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2016-05-19 18:25 UTC (permalink / raw)
To: xypron.glpk; +Cc: sgoutham, rric, linux-arm-kernel, netdev, linux-kernel
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Tue, 17 May 2016 21:40:38 +0200
> In function bgx_lmac_handler only use a member of
> lmac after checking it is not null.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-19 18:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-17 19:40 [PATCH 1/1] net: thunderx: avoid null pointer dereference Heinrich Schuchardt
2016-05-17 20:21 ` David Daney
2016-05-17 21:37 ` Heinrich Schuchardt
2016-05-19 18:25 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).